Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by patosalas · Aug 29, 2016 at 10:23 AM · animationloopbooleaneventinfinite

Can´t find the infinite loop in this script

Hi, I´m making a game where my character should be able to hit, and only change to idle state (or any other anim state) if the "hit animation" ends. To achieve that I used an event function and a boolean . The thing is that, if I tap rapdly the "S" key (really fast, probably matching the exact frame where the animation event function gets called), the player freezes at the last frame of the hit animation, not the game, but the player. I guess it is an infinite loop since the console doesn´t notify anything. Any ideas??

 using UnityEngine;
 using System.Collections;
 
 public class leono : MonoBehaviour {
 
     public float moveSpeed;
     private Animator animator;
     private bool fighting;
 
 
     void Awake () {
         animator = GetComponent<Animator>();  
     }
 
     // Use this for initialization
     void Start () {
         
 
     }
     
     // Update is called once per frame
     void Update () {
 
 
         //Player hit
         if (Input.GetKeyDown (KeyCode.S)&& !fighting) {
             Debug.Log (" fighting true ");
             fighting = true;
             animator.SetInteger ("leono", 2);
         } 
 
         //Player move right
         else if (Input.GetKey (KeyCode.RightArrow) && !fighting ) {
             transform.localScale = new Vector3 (1f, 1f, 1f);
             animator.SetInteger ("leono", 1);
             GetComponent<Rigidbody2D> ().velocity = new Vector2 (moveSpeed, GetComponent<Rigidbody2D> ().velocity.y);
         }
         //Return to idle from moving right
         if (Input.GetKeyUp (KeyCode.RightArrow)&& !fighting ) {
             animator.SetInteger ("leono", 0);
         }
         //Player move left
         else if (Input.GetKey (KeyCode.LeftArrow)&& !fighting ) {
             transform.localScale = new Vector3 (-1f, 1f, 1f);
             animator.SetInteger ("leono", 1);
             GetComponent<Rigidbody2D> ().velocity = new Vector2 (-moveSpeed, GetComponent<Rigidbody2D> ().velocity.y);
         }
         //Return to idle from moving left
         if (Input.GetKeyUp (KeyCode.LeftArrow)&& !fighting ) {
             animator.SetInteger ("leono", 0);
         }
 
 
     }
 
     //This function gets called at the end of the animation with an animation event
     void defaultState (){
         fighting = false;
         Debug.Log (" fighting false ");
         animator.SetInteger ("leono", 0);
 
     }
 
 }
 
Comment
Add comment · Show 4
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image TanselAltinel · Aug 29, 2016 at 12:54 PM 0
Share

You are setting fighting to true, but you are setting it to false only in defaultState function. Where do you call it?

avatar image patosalas TanselAltinel · Aug 29, 2016 at 04:52 PM 0
Share

Hello, the defaultState function is called in an animation event, which is placed after the last frame of the hitting animation.

avatar image TanselAltinel patosalas · Aug 29, 2016 at 05:39 PM 0
Share

That's it, when you press keys very fast, it sets fighting to true again but you never call defaultState function ever again. You may want to check if animation is finished to S key check.

Show more comments

0 Replies

· Add your reply
  • Sort: 

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

125 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

How to get perfect position animation with root motion? 1 Answer

Add Event in animation from another Gameobject 5 Answers

How to add Animation Events in the Timeline editor? 5 Answers

PROBLEM WITH ANIM.SETBOOL NOT WORKING 0 Answers

Unity Animation 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges