koobas.hobune.stream
My if statement isn't running even though all requirements are true
I am trying to make wander code for my player and the part for it wandering and going around is working however the part that stops the wander and makes it go back into idle doesn't work. I tested it and I know the if statement doesn't trigger and I am unsure why. I know that the player gets close enough to the destination by making the chosen destination public. I have also tried using Mathf.Approximately however that didn't change anything.
Why might this happen? If there is any more code you want/need I can give it to you. (also I got the AnimDoneYet method from https://answers.unity.com/questions/1208395/animator-wait-until-animation-finishes.html)
The wander method:
public void WanderPlayer(GameObject playerPos, Animator anim, NavMeshAgent agent, GameObject self)
{
agent.isStopped = false;
if (coru == false)
{
coru = true;
agent.SetDestination(GetDest(self));
}
anim.SetBool("walk", true);
if (agent.transform.position.magnitude == agent.destination.magnitude + 0.5f || agent.transform.position.magnitude == agent.destination.magnitude - 0.5f) // this is the if statement that is working weird
{
Debug.Log("this works");
state = State.Idle;
if (cro == null)
cro = StartCoroutine(AnimDoneYet(anim));
anim.SetBool("walk", false);
agent.ResetPath();
//agent.destination = new Vector3(self.transform.position.x, self.transform.position.y, self.transform.position.z);
}
}
IEnumerator AnimDoneYet(Animator anim)
{
yield return new WaitForSeconds(anim.GetCurrentAnimatorStateInfo(0).length + anim.GetCurrentAnimatorStateInfo(0).normalizedTime);
}
private Vector3 GetDest(GameObject self)
{
chosenDest = new Vector3(self.transform.position.x + Random.Range(-30, 30), self.transform.position.y, self.transform.position.z + Random.Range(-30, 30));
checkedheight = Instantiate(invis, chosenDest, Quaternion.identity);
downRay = new Ray(checkedheight.transform.position, -transform.up);
upRay = new Ray(checkedheight.transform.position, transform.up);
if (Physics.Raycast(upRay, out hit) || Physics.Raycast(downRay, out hit))
{
if (hit.collider != null && hit.collider == CompareTag("Terrain"))
{
chosenDest.y = hit.collider.transform.position.y;
}
}
return chosenDest;
}
use < or > rather than == when comparing distances etc movement related floating point values. This is because it's hard to predict exactly how much movement is done per frame.
if (agent.transform.position.magnitude < agent.destination.magnitude + 0.5f || agent.transform.position.magnitude > agent.destination.magnitude - 0.5f)
Hello,
coru and cro declarations are missing, I assume they are in the unpublished part?
It seems to me that there are 2 problems:
the use of magnitude
the comparison of floats
1) magnitude measures the length of a vector. Applied to agent.transform.position, it returns the position distance from the center of the world at (0, 0, 0). Ditto for agent.destination.magnitude. This function is quite expensive in terms of computation time, because it uses a square root. You use it 4 times in a function probably called in Update, that is, dozens (or even hundreds) of times per second.
2) for the computer, the floats are represented by a few bytes, a floating number will very rarely be equal to its representation. This makes the comparisons between floats not very deterministic. This is why there is the Mathf.Approximately function.
How do you solve your problem? Quite simply, checking that the distance between the 2 points is smaller than a certain value, something like:
{
public void WanderPlayer (GameObject playerPos, Animator anim, NavMeshAgent agent, GameObject self)
{
if ((agent.transform.position - agent.destination).sqrMagnitude < 0.01f)
{
// Your tasks.
}
}
}
Note: I am using the magnitude squared, which saves the square root calculation. The value of 0.01f corresponds to an actual distance of 10 cm.
