Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by JayFitz91 · Sep 19, 2014 at 08:36 PM · efficient

Help with more efficient code

I would like some help writing some more efficient code, I have this code here:

 public void accel1Check()
     {
         currentAchievement = accel1Description;
         currentAchievement.active = true;
     }
 
     public void accel2Check()
     {
         currentAchievement = accel2Description;
         currentAchievement.active = true;
 
         accel1Description.active = false;
     }

I have my achievements mapped to buttons, when the user presses a button I would like to display the information it holds, the problem now is they overlap each other unless I disable them all when I press on one. This is not efficient as I have around 20 achievements and so would like to minimize the code.

I think I need something like a currentAchievement variable and previous achievement variable which will hold this data but I'm having some trouble figuring it out, if anyone could help here I'd appreciate it

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

2 Replies

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by JayFitz91 · Sep 19, 2014 at 08:43 PM

I've managed to get it working more efficiently, I use a current and previous achievement variable to hold both sets of data, I then use the function at the botton to check whether to previous achievement is set to null, if it is not, I then set the previous achievement to be set to the current achievment, then set the current achievement to that of the new button I press, sounds like a mouthful, hopefully the code makes it clearer:

 public GameObject accel1Description;
     public GameObject accel2Description;
     public GameObject bounce1Description;
     
     private GameObject currentAchievement;
     private GameObject previousAchievement;
     
     void Start()
     {
         previousAchievement = null;   
     }
     
     public void accel1Check()
     {
         checkAchieveIsNull();
 
         currentAchievement = accel1Description;
         currentAchievement.active = true;
     }
 
     public void accel2Check()
     {
         checkAchieveIsNull();
 
         currentAchievement = accel2Description;
         currentAchievement.active = true;
     }
 
     public void bounce1Check()
     {
         checkAchieveIsNull();
 
         currentAchievement = bounce1Description;
         currentAchievement.active = true;
 
     }
 
     void checkAchieveIsNull()
     {
         if (currentAchievement != null)
         {
             previousAchievement = currentAchievement;
             previousAchievement.active = false;
         }
         else
             previousAchievement = null;
     }

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
0

Answer by SnotE101 · Sep 19, 2014 at 08:44 PM

Create an array of booleans controlling each achievement. Then have an int, an achievement number, so achievementBool[achievementNumber] = true.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

25 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Help with code efficiency 1 Answer

Some questions on Unity best practices 1 Answer

Efficient way of having 1 draw call but allowing for debris physics [Mobile] 1 Answer

What's the best way to make a long scrolling list of items? 0 Answers

Can I disable lighting for efficiency? 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges