Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 14 Next capture
2021 2022 2023
2 captures
12 Jun 22 - 14 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by jsams_unity · Mar 23, 2020 at 11:15 PM · procedural generationoverlappingdungeon

Dungeon rooms overlapping

I've been trying to figure this out but can't see where I've gone wrong.

I am creating a dungeon generator that uses a grid made up of cells. I want to create rooms that are comprised of cells and that don't overlap rooms that have already been generated. The issue is that rooms do overlap.

Here is my overlap function:

 public bool IsOverlapping(Room other)
 {
     return !((this.right < other.left)
           || (this.left > other.right)
           || (this.top < other.bottom)
           || (this.bottom > other.top));
 }

When I'm generating the rooms, I use the below code to check for overlaps:

 for (int i = 0; i < maxRoomPlaceAttempts; i++)
 {
     if (rooms.Count >= maxRoomCount)
         break;
 
     Vector2Int roomSize = new Vector2Int(Random.Range(minRoomSize.x, maxRoomSize.x + 1),
                                          Random.Range(minRoomSize.y, maxRoomSize.y + 1));
 
     int startRow = Random.Range(0, rowCount - roomSize.y);
     int startCol = Random.Range(0, colCount - roomSize.x);
     int endRow = startRow + roomSize.y;
     int endCol = startCol + roomSize.x;
 
     Room newRoom = new Room(this, startCol, startRow, endCol, endRow);
 
     foreach (Room other in rooms)
     {
         if (newRoom.IsOverlapping(other))
         {
             Debug.Log("New room is overlapping, skipping...");
             goto NEXT_ROOM;
         }
     }
 
     rooms.Add(newRoom);
 
     NEXT_ROOM:;
 }

As far as I can tell it should be avoiding all overlaps but it always gives me several rooms that overlap. Where am I going wrong?

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

0 Replies

· Add your reply
  • Sort: 

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

125 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Procedural generation seed that can be manipulated 0 Answers

Checking if object intersects? 1 Answer

Why is it that my planets aren't overlapping with each other on spawn, but they do appear to be overlapping with my sun? 1 Answer

Overlapping meshes create weird rendering problem 1 Answer

check box overlap / colliders in edit mode 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges