Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 14 Next capture
2021 2022 2023
2 captures
12 Jun 22 - 14 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by FelixTheWolfrick · Jan 26, 2020 at 10:40 PM · scripting problemmovementgrid based gamerandomspawningrandomization

,Script only working for one objects and not the others

I'm trying to make a board game for my game prod class. We only have 2 weeks to put a prototype together but I'm having an issue with my NPCs and getting them to all move randomly at the end of each turn. Currently there are 11 NPCs and they all have the same script attached. They all move to their start positions but then only one of them moves each time. Considering I don't have much time I might just make 11 versions of the script but I also know there's a fix to the issue. (Also the boundaries system is a bit iffy but that's not a main concern rn I can fix it later)

using System.Collections; using System.Collections.Generic; using UnityEngine;

 public class NPCManager : MonoBehaviour
 {
     //Variables
     //Movement
     public float startX;
     public float startY;
     private int dice; //Random Generated Number 1-4 to decide what direction they'll move in
     private float move = 1.37f;
     private float minY = -6.79f; //Down
     private float maxY = 6.91f; //Up
     private float minX = -9.63f; //Left
     private float maxX = 9.54f; //Right
     //Turn System
     public static bool npcTurn = false;
     private int turnChoice; //Random Generated Number 1-10 to decide who goes next
 
     // Start is called before the first frame update
     void Start()
     {
         //Place NPC
         transform.position = new Vector2(startX, startY);
 
         Debug.Log("NPC Start: " + gameObject.name);
     }
 
     //Randomly Move NPCs
     private void MoveNPC()
     {
         if (npcTurn == true)
         {
             dice = Random.Range(1, 4);
             switch (dice)
             {
                 //Left
                 case 1:
                     if (startY > minY || startY == minY)
                     {
                         startY += move;
                         transform.position = new Vector2(startX, startY);
                         npcTurn = false;
                         turnChoice = Random.Range(1, 10);
                         Debug.Log("Turn Choice #" + turnChoice);
                         if (turnChoice < 5)
                         {
                             BlueCultist.blueTurn = true;
                             Debug.Log("Blues Turn After NPC");
                         }
                         else
                         {
                             OrangeCultist.orangeTurn = true;
                             Debug.Log("Oranges Turn After NPC");
                         }
                     }
                     else
                     {
                         startY -= move;
                         transform.position = new Vector2(startX, startY);
                         npcTurn = false;
                         turnChoice = Random.Range(1, 10);
                         Debug.Log("Turn Choice #" + turnChoice);
                         if (turnChoice < 5)
                         {
                             BlueCultist.blueTurn = true;
                             Debug.Log("Blues Turn After NPC");
                         }
                         else
                         {
                             OrangeCultist.orangeTurn = true;
                             Debug.Log("Oranges Turn After NPC");
                         }
                     }
                     break;
                 //Up
                 case 2:
                     if (startX < maxX || startX == maxX)
                     {
                         startX -= move;
                         transform.position = new Vector2(startX, startY);
                         npcTurn = false;
                         turnChoice = Random.Range(1, 10);
                         Debug.Log("Turn Choice #" + turnChoice);
                         if (turnChoice < 5)
                         {
                             BlueCultist.blueTurn = true;
                             Debug.Log("Blues Turn After NPC");
                         }
                         else
                         {
                             OrangeCultist.orangeTurn = true;
                             Debug.Log("Oranges Turn After NPC");
                         }
                     }
                     else
                     {
                         startX += move;
                         transform.position = new Vector2(startX, startY);
                         npcTurn = false;
                         turnChoice = Random.Range(1, 10);
                         Debug.Log("Turn Choice #" + turnChoice);
                         if (turnChoice < 5)
                         {
                             BlueCultist.blueTurn = true;
                             Debug.Log("Blues Turn After NPC");
                         }
                         else
                         {
                             OrangeCultist.orangeTurn = true;
                             Debug.Log("Oranges Turn After NPC");
                         }
                     }
                     break;
                 //Right
                 case 3:
                     if (startY < maxY || startY == maxY)
                     {
                         startY -= move;
                         transform.position = new Vector2(startX, startY);
                         npcTurn = false;
                         turnChoice = Random.Range(1, 10);
                         Debug.Log("Turn Choice #" + turnChoice);
                         if (turnChoice < 5)
                         {
                             BlueCultist.blueTurn = true;
                             Debug.Log("Blues Turn After NPC");
                         }
                         else
                         {
                             OrangeCultist.orangeTurn = true;
                             Debug.Log("Oranges Turn After NPC");
                         }
                     }
                     else
                     {
                         startY += move;
                         transform.position = new Vector2(startX, startY);
                         npcTurn = false;
                         turnChoice = Random.Range(1, 10);
                         Debug.Log("Turn Choice #" + turnChoice);
                         if (turnChoice < 5)
                         {
                             BlueCultist.blueTurn = true;
                             Debug.Log("Blues Turn After NPC");
                         }
                         else
                         {
                             OrangeCultist.orangeTurn = true;
                             Debug.Log("Oranges Turn After NPC");
                         }
                     }
                     break;
                 //Down
                 case 4:
                     if (startX > minX || startX == minX)
                     {
                         startX += move;
                         transform.position = new Vector2(startX, startY);
                         npcTurn = false;
                         turnChoice = Random.Range(1, 10);
                         Debug.Log("Turn Choice #" + turnChoice);
                         if (turnChoice < 5)
                         {
                             BlueCultist.blueTurn = true;
                             Debug.Log("Blues Turn After NPC");
                         }
                         else
                         {
                             OrangeCultist.orangeTurn = true;
                             Debug.Log("Oranges Turn After NPC");
                         }
                     }
                     else
                     {
                         startX -= move;
                         transform.position = new Vector2(startX, startY);
                         npcTurn = false;
                         turnChoice = Random.Range(1, 10);
                         Debug.Log("Turn Choice #" + turnChoice);
                         if (turnChoice < 5)
                         {
                             BlueCultist.blueTurn = true;
                             Debug.Log("Blues Turn After NPC");
                         }
                         else
                         {
                             OrangeCultist.orangeTurn = true;
                             Debug.Log("Oranges Turn After NPC");
                         }
                     }
                     break;
             }
         }
     }
 
     // Update is called once per frame
     void Update()
     {
         MoveNPC();
     }
 }
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
â–¼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1

Answer by Krixion · Jan 26, 2020 at 11:08 PM

It's because you are using a static bool for the NPC turn. Static variables are a global definition so changing it to true on one NPC will change it to true on all of your NPC objects.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
â–¼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

255 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

AI Movement Direction 0 Answers

Character triple+ Jumping: Please Help! 0 Answers

Slime script? 1 Answer

How to instantiate an object and have it rise from/through the ground? 1 Answer

How do I setup fixed movement between predetermined tiles? 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges