I'm trying to make a potion for my health system but I don't know how to access public properties from another code. When I though I had it, the game stop updating my Health.

Question

My Health code using System.Collections; using System.Collections.Generic; using UnityEngine; using UnityEngine.SceneManagement;

public class HeartSystemNolimit : MonoBehaviour { public GameObject[] hearts; private int life; private int maxLife; private bool dead;

private void Start() { life = hearts.Length; maxLife = life; }

 void Update()
 {
     if (dead == true)
     {
         // set gameover scene or reload level
         SceneManager.LoadScene(SceneManager.GetActiveScene().name); //reload level code
     }
 }
 public void TakeDamage(int d)
 {
     life -= d;
     //Destroy (hearts[life].gameObject);
     hearts[life].gameObject.SetActive(false);
     if(life < 1)
     {
         dead = true;
     }
 }
 public void AddLife()
 {
     if(life < maxLife)
     {
         hearts[life].gameObject.SetActive(true);
         life += 1;
     }
   

 }
 void OnTriggerEnter2D(Collider2D other)

 {
    
     Bullet bullet = other.GetComponent<Bullet>();

     if (bullet != null)
     {
         TakeDamage(1);
     }


    // Destroy(gameObject);

 }

}

My failed potion code using System; using System.Collections; using System.Collections.Generic; using UnityEngine; using UnityEngine.Events;

public class Health : MonoBehaviour { public UnityEvent interact; private void OnTriggerEnter2D(Collider2D other)

 {
     interact.Invoke();
     Destroy(gameObject);
 }
 //Destroy(gameObject);

}

Answer 1

Answer by Sacaitha · Apr 27 at 09:08 PM

Check if "other" contains the component first; if(other.GetComponent()) { //code }

Add comment · Show 1 · Share

Patpig10 · Apr 28 at 12:20 PM 0

Share

For the health system it has Bullet bullet = other.GetComponent();

     if (bullet != null)
     {
         TakeDamage(1);
     }

and the potion only have void OnTriggerEnter2D(Collider2D other)

I don't really understand your question.

Answer 2

Answer by Caeser_21 · Apr 28 at 12:30 PM

Why can you just call AddLife in the collision event? Something like :

 public void OnTriggerEnter2D(Collider2D other)
 {
      if (other.transform.tag == "Player")
      {
          HeartSystemNolimit Health = other.GetComponent<HeartSystemNolimit>();
          Health.AddLife();
      }
 }

NOTE : Your player tag has to be "Player" for this to work...

Add comment · Show 6 · Share

Patpig10 · Apr 28 at 01:49 PM 0

Share

Now I'm getting this error

Assets\Code\Enemy\Health.cs(9,5): error CS1520: Method must have a return type

This is the code now. public class Health : MonoBehaviour { OnTriggerEnter2D(Collider2D other) { if (other.tag == "Player") { other.GetComponent().AddLife(); } } }

Caeser_21 Patpig10 · Apr 28 at 02:03 PM 0

Share

Fixed the code, now I think it should work...

Patpig10 Caeser_21 · Apr 28 at 02:12 PM 0

Share

Nope same error

Show more comments

I'm trying to make a potion for my health system but I don't know how to access public properties from another code. When I though I had it, the game stop updating my Health.

2 Replies

Your answer

Follow this Question

Related Questions