Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by dev227 · Oct 07, 2017 at 10:34 PM · scripting problemcollidersnullreferenceexceptionexceptions

How to change variable in another script after colliding?

Hello guys!

I'm making my first unity game right now, and I'm stuck with changing variables after a collision.

So:

I have an object named pistol that has a script Shooting.cs where I have variable int ammo.

alt text

And then I have a cube that after colliding, ammo variable should change. The name of a script inside the cube is AmmoPack.cs

alt text

AmmoPack.cs code looks like that:

   using System.Collections;
     using System.Collections.Generic;
     using UnityEngine;
     
     public class AmmoPack : MonoBehaviour
     {
         private Shooting shooting;
         private Transform gun;
         void Start()
         {
             gun = transform.Find("Main Camera/FPSController/FirstPersonCharacter/pistol");
             shooting = gun.GetComponent<Shooting>();
         }
     
     
         void Update()
         {
     
         }
     
         void OnTriggerEnter(Collider other)
         {
             shooting.ammo = 0;
         }
     }

But it keeps giving me Object reference not set to an instance of an object exception.

What should I do?

1u.png (3.5 kB)
2u.png (7.0 kB)
Comment
Add comment · Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image tormentoarmagedoom · Oct 09, 2017 at 08:18 AM 0
Share

at wich line it gives you the error? At line 23? then check if "shooting" was good refered, or if is "gun" and reply

2 Replies

· Add your reply
  • Sort: 
avatar image
1

Answer by Dragate · Oct 09, 2017 at 08:42 AM

Remove

      private Shooting shooting;
      private Transform gun;
      void Start()
      {
          gun = transform.Find("Main Camera/FPSController/FirstPersonCharacter/pistol");
          shooting = gun.GetComponent<Shooting>();
      }

and change

 void OnTriggerEnter(Collider other)
      {
          shooting.ammo = 0;
      }

to

 void OnTriggerEnter(Collider other) {
        Shooting shooting = other.gameObject.GetComponentInChildren<Shooting>();
        if(shooting != null){
              shooting.ammo = 0;
        }
 }
Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
0

Answer by tormentoarmagedoom · Oct 09, 2017 at 08:33 AM

As you said, this script AmmoPack is inside the Cube object.

But then you are using:

 transform.Find();

which looks for transforms childs of the object where this script is placed. (In this case is looking for childs of Cube, and they don't exist).

Maybe you should crate a TAG for the pistol like "Weapon" and use:

 gun = GameObject.FindWithTag("Weapon");

Which looks for GameObjects in the scene with this Tag.

You can also use GameObject.FindGameObjectsWithTag (with an "s" that make an array of all objects in the scene with this tag)

If using the FindWithTag be sure there is always only 1 GameObject in the scene with the tag Weapon.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

123 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Photon multiplayer trying to enable scripts and getting NullReferenceException 0 Answers

OnCollisionEnter for other gameobjects (C#) 2 Answers

AppDomain.UnhandledException on Android 0 Answers

Random: NullReferenceException: Object reference not set to an instance of an object 2 Answers

OnTriggerEnter does not work 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges