Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
This question was closed Sep 10, 2020 at 05:46 AM by theyukonschoice for the following reason:

The question is answered, right answer was accepted

avatar image
0
Question by theyukonschoice · Nov 28, 2018 at 03:49 AM · timershooting

my timer isnt working for my firerate! it instantiates too many objects at a time,HOw can i get my shot timer working properly? it instantiates too many objects at a time

 using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
 
 public class EnemyProjectile : MonoBehaviour
 {
      public GameObject projectile;
      public GameObject spawnPoint;
      public float fireRate = .1f;
      private bool Shooting;
 
 
      private float timer = 1;
      // Update is called once per frame
      void Update()
      {
 
           Shoot();
 
      }
 
      public void Shoot()
      {
 
           StartCoroutine("ShotTimer");
          if (Shooting)
           {
                GameObject spawnProjectile = Instantiate(projectile, spawnPoint.transform.position, 
                Quaternion.identity);
                spawnProjectile.transform.rotation = transform.rotation;
                spawnProjectile.GetComponent().GiveInitialVelocity();
           }
 
      }
 
      public IEnumerator ShotTimer()
      {
           yield return new WaitForSeconds(1);
           Shooting = true;
           yield return new WaitForSeconds(1);
           Shooting = false;    
      }    
 }

I had

 timer = 1/fireRate;
 timer -= time.deltatime;
 if (timer <= 0)
 {
      GameObject spawnProjectile = Instantiate(projectile, spawnPoint.transform.position, 
      Quaternion.identity);
      spawnProjectile.transform.rotation = transform.rotation;
      spawnProjectile.GetComponent().GiveInitialVelocity();
 }


but it just spawns a ton of projectiles that all collide. please help

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

2 Replies

  • Sort: 
avatar image
0
Best Answer

Answer by mlnczk · Nov 28, 2018 at 10:06 AM

 private Start(){
    StartCoroutine(ShootTimer());
 }
 
 private IEnumerator ShootTimer(){
    while (true){
        yield return new WaitForSeconds(1f);
        Shoot();
     }
 }

Declaring coroutine in start and adding while(true) will make it repeat itself every WaitForSeconds you added. This way you avoid update which is always good to make it as light code as possible and as soon as your object starts will begin shooting.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
0

Answer by Legend_Bacon · Nov 28, 2018 at 10:02 AM

Hello there,


Your problem lies in how many times you call your function and coroutine.


Update() runs 60 times a second. This means you're calling Shoot() 60 times a second. Which means you're calling the ShotTimer coroutine 60 times a second. Is this really what you want?


You should probably only call Shoot() once when actively shooting (on user Input KeyDown, for example).


If the behaviour you want is different from that, please say so in your description of the problem. Right now we can't be certain of what you are expecting this code to do.


I hope that helps!

Cheers,

~LegendBacon

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Follow this Question

Answers Answers and Comments

100 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

How can I rotate a shooting-practice target 180 degrees with a timer in C#? 1 Answer

Start timer with Input 2 Answers

Issue with Timed Shooting in C# 1 Answer

Cannot convert `lambda expression' to non-delegate type `bool' 1 Answer

Best time and saving best time 3 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges