Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
1
Question by John Murphy · Dec 15, 2012 at 03:17 AM · arraynetwork

Array index out of range?

OK, so I have a network script, everything works fine up to the point were a user joins a server, is asked for a password, then clicks connect. But when the user clicks connect i get and error Array index out of range. Here is the code:

 var gameName:String = ""; 
 var serverName:String = "";
 var showTextField:boolean;
 var showPassField:boolean;
 
 private var connect:boolean;
 private var canStart = false;
 private var fontStyle : GUIStyle;
 private var passWord:String = "";
 private var passAtemp:String = "";
 private var refreshing:boolean;
 private var hostData:HostData[];
 
 private var btnX:float;
 private var btnY:float;
 private var btnW:float;
 private var btnH:float;
 
 function Start(){
     btnX = Screen.width * 0.05;
     btnY = Screen.width * 0.05;
     btnW = Screen.width * 0.1;
     btnH = Screen.width * 0.1;
     }
 
 function startServer(){
     Network.incomingPassword = passWord;
     Network.InitializeServer(6, 25000, !Network.HavePublicAddress);
     MasterServer.RegisterHost(gameName, serverName, "test game");
     }
 
 
 function refreshHostList(){
     MasterServer.RequestHostList(gameName);
     refreshing = true;
 }
 
 function Update(){
     if(refreshing){
         if(MasterServer.PollHostList().Length > 0){    
             refreshing = false;
             Debug.Log(MasterServer.PollHostList().Length);
             hostData = MasterServer.PollHostList();
             }
         }
     }
 function OnServerInitialized(){
     Application.LoadLevel("Lobby");
     Debug.Log("Server Initialized");
     
     
 }
 function OnMasterServerEvent(mse:MasterServerEvent){
     if(mse == MasterServerEvent.RegistrationSucceeded){
         Debug.Log("Registared Server");
         }
     }
 
 
 function OnGUI(){
                 
     if(showPassField){    
         GUI.Label(Rect (btnX * 6, btnY * 4, btnW * 2, btnH * 0.5), "Enter server Password: ");
         passAtemp = GUI.TextField(Rect (btnX * 8, btnY * 4, btnW * 2, btnH * 0.2), passAtemp, 12);
     if(GUI.Button(Rect(btnX * 7, btnY * 5, btnW, btnH * 0.5), "Connect")){
         connect = true;
         Debug.Log("Pass");
     }
 }
     
     if(showTextField){
         GUI.Label(Rect (btnX * 6, btnY * 3, btnW * 2, btnH * 0.5), "Enter server name: ");
         serverName = GUI.TextField(Rect (btnX * 8, btnY * 3, btnW * 2, btnH * 0.2), serverName, 25);
         GUI.Label(Rect (btnX * 6, btnY * 4, btnW * 2, btnH * 0.5), "Enter server Password: ");
         passWord = GUI.TextField(Rect (btnX * 8, btnY * 4, btnW * 2, btnH * 0.2), passWord, 12);
         if(GUI.Button(Rect(btnX * 7, btnY * 5, btnW, btnH * 0.5), "Start")){
             startServer();
         }
         if(GUI.Button(Rect(btnX * 11, btnY * 5, btnW, btnH * 0.5), "Cancel")){
             Application.LoadLevel("Menu");
         }
     }
     
     if(!Network.isClient && !Network.isServer && !showTextField){
         
                 if(GUI.Button(Rect(btnX, btnY, btnW, btnH), "Start Server")){
                     showTextField = true;
                     Destroy(GameObject.FindWithTag("Menu"));
                     Debug.Log("Starting Server");
             }
 
     if(GUI.Button(Rect(btnX, btnY * 1.2 + btnH, btnW, btnH), "Refresh Host")){
             Debug.Log("Refreshing");
             refreshHostList();
         }
         
     if(GUI.Button(Rect(btnX, btnY * 3.4 + btnH, btnW, btnH), "Exit")){
             Application.Quit();
             }
             
     if(hostData){
         for(var i:int = 0; i<hostData.length; i++){
             if(GUI.Button(Rect(btnX * 2 + btnW, btnY*1.2 + (btnH * i), btnW * 3, btnH*.5),hostData[i].gameName + "" +hostData[i].connectedPlayers + "/6")){
                 showPassField = true;
                 Destroy(GameObject.FindWithTag("Menu"));
                 
                 }
             }
         if(connect){
             Network.Connect(hostData[i],passAtemp);
             }
         }
     }
 }
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

3 Replies

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by whydoidoit · Dec 15, 2012 at 01:36 PM

Your problem is that the

 if(connect) {
       Network.Connect(hostData[i], passAtemp);
  }

is outside the for next loop and so the value of i is guaranteed to be = to the length of the array and hence be an index out of range exception.

I can't quite work out what you are trying to do with that line - but it's guaranteed to fail at present.

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image clunk47 · Dec 15, 2012 at 04:56 PM 0
Share

Good answer Sir. +1

avatar image
0

Answer by totru · Dec 15, 2012 at 01:55 PM

You problem is the last statement. As the index of a for loop is increased on each turn it is hostData.length after the loop (else the loop wouldn't be left). But as an array is zero based, you ask for an element outside the range.

 Network.Connect(hostData[i-1], passAtemp);

should do the job.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
0

Answer by RobbingDaHood · Dec 15, 2012 at 01:53 PM

The code in the end

 for(var i:int = 0; i<hostData.length; i++){

needs to be

 for(var i:int = 0; i<hostData.length - 1; i++){
Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

13 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

The name 'Joystick' does not denote a valid type ('not found') 2 Answers

Instantiate into array : Out of range? 1 Answer

Help|sync movement in multiplayer 1 Answer

array.length read only? workaround? 2 Answers

applying a value to all items in an array[] 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges