Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Sovraya · Oct 28, 2012 at 04:01 AM · c#listnullreferenceexception

C# NullReferenceException

Hi,

When I start my game I get this error:

NullReferenceException: Object reference not set to an instance of an object PlayerAttack.Start () (at Assets/Standard Assets/Scripts/PlayerAttack.cs:19)

And I don't know why. I don't have much experience in programming, so it might be a very noobish question :P

Basically I am trying to get a List from another script (PlayerKnowledge), then copy the content into a new List<>Knowledge here in the PlayerAttack script, so I can later on iterate through the content, and if something is equal to a specific string, then a specific attack should happen.

Here is the code:

 public class PlayerAttack : MonoBehaviour {
     private PlayerKnowledge playerKnowledge;
     private List<string> knowledge = new List<string>();
     
     // Use this for initialization
     void Start () {
 
                 //This is the line where the error occurs
         var know = playerKnowledge.knownNames;
     
                 //And if someone knows how to print out content of a List,
                 // I would be grateful to know :P 
         Debug.Log("know returns" + know);
         
         if(know != null){
         knowledge.AddRange(know);
         Debug.Log("knowledge !null returns: " + knowledge);
         }
         
     }
 using UnityEngine;
 using System.Collections;
 using System.Collections.Generic;
 
 public class PlayerKnowledge : MonoBehaviour {
     public List<string> knownNames; 
     public GameObject item;
 
     private GameObject book; 
     
     // Use this for initialization
     void Start () {
         var knownNames = new List<string>();
         knownNames.Add("Test");
         
         Debug.Log("PlayerKnowledge Start: " + knownNames);
         
     }
     
     // Update is called once per frame
     void Update () {
         
         if(Input.GetKey(KeyCode.R)) {
             readBook();    
         }
     }
     
     //reads the targeted book
     private void readBook() {
                 
                 BookFolklore bf = (BookFolklore)item.GetComponent("BookFolklore");
                 string name = bf.bookName;
                 
                 knownNames.Add (name);
                 
             }
 
 }

Anyone who can help me with this? Let me know if you need more information.

Comment
Add comment · Show 2
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image DaveA · Oct 28, 2012 at 04:03 AM 0
Share

Those 'using' statements should come first.

avatar image Sovraya · Oct 28, 2012 at 04:11 AM 0
Share

Yeah, they are in the actual code :)

2 Replies

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by Landern · Oct 30, 2012 at 07:40 PM

First, use awake to instantiate the list. Second, you made knownNames a local in Start, i would have figured it would have complained(unity console), but i guess it didn't.


 public class PlayerKnowledge : MonoBehaviour {
     public List<string> knownNames; 
     public GameObject item;
 
     private GameObject book; 
  
     void Awake() {
        knownNames = new List<string>();
     }
 
     // Use this for initialization
     void Start () {
        knownNames.Add("Test");
 
        Debug.Log("PlayerKnowledge Start: " + knownNames);
 
     }
 
     // Update is called once per frame
     void Update () {
 
        if(Input.GetKey(KeyCode.R)) {
          readBook();  
        }
     }
 
     //reads the targeted book
     private void readBook() {
 
           BookFolklore bf = (BookFolklore)item.GetComponent("BookFolklore");
           string name = bf.bookName;
 
           knownNames.Add (name);
 
          }
 
 }
Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Sovraya · Oct 31, 2012 at 01:04 AM 0
Share

Great, thanks for the help :)

avatar image
0

Answer by DaveA · Oct 28, 2012 at 04:05 AM

You are using playerKnowledge before setting it to anything. Either drag something onto it in the Insector (an object with one of those on it) or use GameObject.Find and/or GetComponent to get an instance of it.

Comment
Add comment · Show 2 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Sovraya · Oct 28, 2012 at 04:17 AM 0
Share

But Player$$anonymous$$nowledge is just a script attached to the Player where I start up a en empty List that should eventually be filled up with strings each time the player reads a book. What should I then try setting player$$anonymous$$nowledge to? =/

avatar image DaveA · Oct 30, 2012 at 07:12 PM 0
Share

In this script you can either use the Inspector to drag the object onto itself, or in code:

void Start() { player$$anonymous$$nowledge = GetComponent<Player$$anonymous$$nowledge>();

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

11 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Why do I keep getting NullReferenceException in Unity while iterating over a List (in OnDrawGizmos)? 2 Answers

A node in a childnode? 1 Answer

My Project doesn't work - Generic.List throws NullReferenceException ?! 0 Answers

How to null-reference check a Collider2D that's been destroyed 1 Answer

C# NullReferenceException 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges