Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Sovraya · Oct 28, 2012 at 06:06 AM · c#listnullreferenceexception

C# NullReferenceException

Hi,

I keep getting this error when I start my game:

NullReferenceException: Object reference not set to an instance of an object PlayerAttack.Start () (at Assets/Standard Assets/Scripts/PlayerAttack.cs:19)

And I don't know what to do with it. Basically I'm trying to copy the content from a List KnownNames in script PlayerKnowledge, into a new List<> Knowledge in script PlayerAttack. Then I can further down in PlayerAttack compare a specific string with the content in Knowledge<>, and if the string exists there, then do a specific attack.

Any help would be greatly appreciated :)


 using UnityEngine;
 using System;
 using System.Collections;
 using System.Collections.Generic;
 
 public class PlayerAttack : MonoBehaviour {
     public GameObject target;
     private PlayerKnowledge playerKnowledge;
     private List<string> knowledge = new List<string>();
     
     // Use this for initialization
     void Start () {
         
     //This is the line the error points to
         var know = playerKnowledge.knownNames;
     
         //Anyone know how to print content of List<> BTW?
         Debug.Log("know returns" + know);
         
         if(know != null){
         knowledge.AddRange(know);
         Debug.Log("knowledge !null returns: " + knowledge);
         }
         
     }



 using UnityEngine;
 using System.Collections;
 using System.Collections.Generic;
 
 public class PlayerKnowledge : MonoBehaviour {
     public List<string> knownNames; 
     public GameObject item;
     private GameObject book; 
     
     // Use this for initialization
     void Start () {
         var knownNames = new List<string>();
         knownNames.Add("Test");
         
         Debug.Log("PlayerKnowledge Start: " + knownNames);
         
     }

 
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
3
Best Answer

Answer by phodges · Oct 28, 2012 at 06:46 AM

I don't see where playerKnowledge is being initialised in your code. If you don't initialise it then as soon as you try to dereference it to obtain 'knownNames' you will see the exception you describe.

Given the names of your classes, I suspect that they are both found as components on your player object. If that's the case, then use a line like this in PlayerAttack.Start:

 playerKnowledge = GetComponent<PlayerKnowledge>();
 if (null == playerKnowledge){
  Debug.LogError("PlayerKnowledge not found. This code will crash");
 }

If you know that an object with a PlayerAttack component must always have a PlayerKnowledge component too, then you might consider using a [RequireComponent(typeof(PlayerKnowledge))] tag to describe your attack component, otherwise add a null test before var know = ...

Comment
Add comment · Show 2 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Sovraya · Oct 28, 2012 at 07:26 AM 0
Share

That worked! Thanks for great advice! :)

avatar image phodges · Oct 28, 2012 at 07:30 AM 0
Share

Glad it helped. Please press the button to accept the answer.

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

11 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Why do I keep getting NullReferenceException in Unity while iterating over a List (in OnDrawGizmos)? 2 Answers

A node in a childnode? 1 Answer

C# NullReferenceException 2 Answers

My Project doesn't work - Generic.List throws NullReferenceException ?! 0 Answers

How to null-reference check a Collider2D that's been destroyed 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges