koobas.hobune.stream
Singelton ScriptableObject or Static class?
I am pretty new to C#...and trying to learn C# and Unity...so i am writing a small game. I learned about the Singleton pattern and all. And made previous games with singleton classes like a "LevelLoader" and a "Music Player". Then i read this article: https://connect.unity.com/p/singleton-scriptableobject
And scriptable objects are also new to me. But i think i get it. In on of my earlier games i had a "GameData" class that implements the singleton pattern. But i remember it was a pain to test in other scenes. So this is a pretty good class to turn into a Singleton Scriptable Object (it just holds values that travels from scene to scene).
However, this class:
public class LevelLoader : MonoBehaviour
{
public static LevelLoader Instance { get; private set; }
private void Awake()
{
if (Instance == null)
{
Instance = this;
DontDestroyOnLoad(this);
}
else
{
gameObject.SetActive(false);
Destroy(gameObject);
}
}
public void LoadSummaryScene()
{
SceneManager.LoadScene("SummaryScene");
}
public int GetActiveSceneIndex()
{
return SceneManager.GetActiveScene().buildIndex;
}
public string GetActiveSceneName()
{
return SceneManager.GetActiveScene().name;
}
public void LoadSceneByIndex(int _index)
{
SceneManager.LoadScene(_index);
}
public void LoadSceneByName(string _name)
{
SceneManager.LoadScene(_name);
}
}
This class is used in several scenes...but it holds no values...so this is better to use it as a static class right? Because there is no values to edit and it needs to be accessed through several scenes.
If it would hold alot of properties it would be better as a Singleton SO?
Am i right?
Why do you need your class to be a MonoBehaviour in this case? Just remove that inheritance and you'll be fine using this class from every scene. You also need to change your code a bit:
public class LevelLoader
{
static LevelLoader _instance;
public static LevelLoader Instance
{
get
{
if (_instance == null)
_instance = new LevelLoader();
return _instance;
}
}
// the rest of your code
}
If you need to have some values(properties) with this object AND tweak them in the inspector, then use a Singleton ScriptableObject.
Now i am confused.
Looks like a singleton pattern on a class....i though they where bad and you should only use it with SO. But since i don´t need objects of it...maybe should be static? Why should i have an object from it (_instance = new LevelLoader())? There is no reason to return an object.
The pattern is bad, not the way how it's implemented (singleton, static, singleton SO). I mean there's nothing wrong with using singletons, if done carefully. Unity's API is also quite singleton-based.
Anyone else have an opinion about this?
