Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by henkesky · Apr 20, 2016 at 08:26 PM · c#uiunity5

My TakeDamage function doesnt work

Hello everyone, am stuck with my project. When i call my TakeDamage function, the health slider doesn't get reduced. Here is my code and screen shoots.

 using UnityEngine;
 using System.Collections;
 using UnityEngine.UI;
 
 namespace s3
 {
 
  public class PlayerHealth : MonoBehaviour {
 
     public int StartingHealth = 100;
     public int CurrentHealth;
     public Slider HealthSlider;
 //    public Image DamageImage;
 //    public float FlashSpeed = 5f;
 //    public Color FlashColor = new Color(1f, 0f, 0f, 0.1f);
   //  public TankShooting PlayerShooting;
   //  public CarController CarControl;
 
     bool IsDead;
     bool Damaged;
     // Use this for initialization
     void Awake () {
         CurrentHealth = StartingHealth;
         HealthSlider = GetComponent<Slider> ();
       //  PlayerShooting.GetComponent<TankShooting> ();
      //   CarControl = GetComponent<CarController> ();
         
     }
 
     public void TakeDamage (int amount)
     {
             CurrentHealth -= amount;
             HealthSlider.value = CurrentHealth;
 
             if (CurrentHealth <= 0 && !IsDead) 
             {
                 Death ();
             }
     }
 
     void Death ()
     {
         //    PlayerShooting.enabled = false;
         //    CarControl.enabled = false;
     }
 
     void Start () {
     
     }
     
     // Update is called once per frame
     void Update () {
     
     }
   }
 }

This is the code where the TakeDamage function is called

  ![using UnityEngine;
     using UnityEngine.UI;
     
     namespace s3
     {
     
     public class TankShooting : MonoBehaviour
      {
         public int m_PlayerNumber = 1;       
         public Rigidbody m_Shell;            
         public Transform m_FireTransform;           
         public AudioSource m_fireSound;
         public ParticleSystem m_muzzleFlashTurret;
         public Light m_light;
         PlayerHealth playerHealth;
         public int damage;
         GameObject player;
         private string m_FireButton;         
         private float m_CurrentLaunchForce = 6000f;          
         private bool m_Fired;                
     
     
         private void OnAwake()
         {
             m_fireSound = GetComponent<AudioSource>();
             m_Shell = GetComponent<Rigidbody>();
             m_light = GetComponent<Light> ();
             player = GameObject.FindGameObjectWithTag ("Cube");
             playerHealth = player.GetComponent<PlayerHealth>();
         }
     
     
         private void Start()
         {
             m_FireButton = "Fire" + m_PlayerNumber;
             m_light.enabled = false;
     
         }
         
     
         private void Update()
         {
             // Track the current state of the fire button and make decisions based on the current launch force.
            if(Input.GetButtonDown (m_FireButton)) {
                 playerHealth.TakeDamage (damage);
                 Fire();
                 m_light.enabled = true;
             }
             if (Input.GetButton (m_FireButton)) {
                 Fire();
                 m_light.enabled = true;
             }
             if (Input.GetButtonUp (m_FireButton)) {
                 m_light.enabled = false;
             }
         }
     
     
     
         private void Fire()
         {
             // Instantiate and launch the shell.
             m_Fired = true;
             Rigidbody shellInstance = Instantiate (m_Shell, m_FireTransform.position, m_FireTransform.rotation) as Rigidbody;
     
         
     
         //    shellInstance.AddForce (m_FireTransform.forward * 6000*Time.deltaTime);
     
             shellInstance.velocity = m_CurrentLaunchForce*m_FireTransform.forward*Time.deltaTime;
     
             // play fireshoot audio
         //    if(m_fireSound.isPlaying) m_fireSound.Stop();
         //    m_fireSound.Play();
     
             // play muzzle flash when turret is fired
             if(m_muzzleFlashTurret.isPlaying) m_muzzleFlashTurret.Stop();
             m_muzzleFlashTurret.Play();
                
          //   playerHealth.TakeDamage (damage);
     
         }
      }
     }][1]


[1]: /storage/temp/68505-screenshot-53.png

screenshot-51.png (297.5 kB)
screenshot-53.png (269.8 kB)
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

0 Replies

· Add your reply
  • Sort: 

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

157 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Second button works 4 times 1 Answer

Unity 5.3 UI Button wont set Select state via script after the parent has been set inactive 0 Answers

Canvas Sorting Layer having issues with Horizontal Layout Group (And override sorting is not working) 1 Answer

how to do on single click fire and on drag appears the joystick and get the input from joystick 0 Answers

Need alternative for onEndEdit on InputField 2 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges