Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by CoalCzar · Apr 28, 2015 at 07:50 PM · shaderunity5cgupgrade

Unity 5 upgrade broke lightmapped shader

Disclaimer: I know little to nothing about shaders.

Hey all, I upgraded a project to Unity 5 that was using a custom shader. Unity has force "upgraded" the shader as well, but now it just renders black. Unity was nice enough to tell me what it did, but I have no idea why it would stop working. I also visited the changes on the Upgrade guide for shaders and didn't see anything that should affect this one (as far as I know)

It gives me three upgrade notes:

 // Upgrade NOTE: commented out 'float4 unity_LightmapST', a built-in variable
 // Upgrade NOTE: commented out 'sampler2D unity_Lightmap', a built-in variable
 // Upgrade NOTE: replaced tex2D unity_Lightmap with UNITY_SAMPLE_TEX2D

The first two seem obvious and harmless enough. The last one also doesn't seem to be a big issue. Nevertheless, the shader does not render anything but black anymore. These are the only changes according to Git, so Unity isn't lying.

Here's the shader with changes noted in comments. Any help is greatly appreciated.

 Shader "CPX_Custom/Mobile/Unlit Lightmapped CG" {
    Properties {
       _MainTex ("Base (RGB)", 2D) = "white" {}
    }
    SubShader {
       Tags { "RenderType"="Opaque" }
       LOD 100
     
     
       Pass {  
         
          CGPROGRAM
          #include "UnityCG.cginc"
          #pragma vertex vertexPass
          #pragma fragment pixelPass
          uniform sampler2D _MainTex;
          // uniform sampler2D unity_Lightmap; 
          uniform float4 _MainTex_ST;
          // uniform float4 unity_LightmapST;
          struct vertexInput{
              float4 vertex    :    POSITION;
              float2 texcoord    :     TEXCOORD0;
              float2 texcoord1:    TEXCOORD1;
          };
          struct vertexOutput{
              float4 pos        :    POSITION;
              float4 UV        :    TEXCOORD0;
          };
          struct pixelOutput{
              float4 color    : COLOR0;
          };
          vertexOutput vertexPass(vertexInput input){
             vertexOutput output;
             output.UV.xy = input.texcoord;
             output.UV.zw = input.texcoord1 * unity_LightmapST.xy + unity_LightmapST.zw;
             output.pos = mul(UNITY_MATRIX_MVP,input.vertex);
             return output;
          }
          pixelOutput pixelPass(vertexOutput input){
              pixelOutput output;
              float4 color = tex2D(_MainTex, TRANSFORM_TEX(input.UV.xy,_MainTex));
          // USED TO BE: float4 lightMap = float4(DecodeLightmap(tex2D(unity_Lightmap, input.UV.zw)),1.0);
              float4 lightMap = float4(DecodeLightmap(UNITY_SAMPLE_TEX2D(unity_Lightmap, input.UV.zw)),1.0);
              output.color = float4(color.rgb*lightMap.rgb,color.a);
              return output;          
          }
          ENDCG
       }
    }
    // Fallback "Unlit/Texture"
 }
Comment
Add comment · Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image meat5000 ♦ · Apr 29, 2015 at 08:05 PM 0
Share

http://docs.unity3d.com/$$anonymous$$anual/UpgradeGuide5-Shaders.html

1 Reply

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by CoalCzar · May 04, 2015 at 11:13 PM

This was a false accusation of the shader. The actual problem was that Unity completely changed its lightmapping process and I didn't realize that huge change, so we lost our lightmaps.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

20 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

How to force the compilation of a shader in Unity? 5 Answers

Unity5 CG Shader get model position. 1 Answer

Problem with custom shader (ShaderLab + Cg) 1 Answer

Unity5 v Unity4 Shader array errors 1 Answer

How to determine shader center? 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges