Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by rtrimble · Oct 11, 2015 at 10:24 PM · unity 5shaderprogrammingcgpoint light

Why is this point light square?

Hey all,

I was writing a shader and thought everything was going great until I added a point light over a larger piece of geometry and noticed that point lights were appearing squared if the geometry didn't fully fit within the range of the light. I was reading that this had to do with the attenuation. However, nothing changes no matter what I do with the attenuation. I've noticed that Unity's default shaders do not do this. Here's an example of the problem:

alt text

I decided to take a step back and try to see if I could get this working on a simpler shader. The lighting is being done on the vertex level. The shader code is below.

 Shader "Custom/FromScratch" {
 
     Properties {
         _Color ("Color", Color) = (1.0, 1.0, 1.0, 1.0)
     }
     
     SubShader {
         
         Pass{
             Tags {"LightMode" = "ForwardBase"}
             
             CGPROGRAM
             
             #pragma vertex vert
             #pragma fragment frag
             
             //user defined
             uniform float4 _Color;
             
             //Unity Defined
             uniform float4 _LightColor0;
             
             struct vertexInput{
                 float4 vertex: POSITION;
                 float3 normal: NORMAL;
             };
             
             struct vertexOutput{
                 float4 pos: SV_POSITION;
                 float4 light : TEXCOORD0;
             };
             
             
             vertexOutput vert(vertexInput v){
                 vertexOutput o;
                 
                 float4 posWorld = mul(_Object2World, v.vertex);
                 
                 float atten;
                 float3 lightDirection;
                 
                 float3 normalDir = normalize(mul(float4(v.normal,1.0), _World2Object).xyz);
                 
                 //lighting
                 if(_WorldSpaceLightPos0.w == 0.0){
                     atten = 1.0;
                     lightDirection = normalize(_WorldSpaceLightPos0.xyz);
                 
                 } else {
                     float3 fragmentToLightSource = _WorldSpaceLightPos0.xyz - posWorld.xyz;
                     float distance = length(fragmentToLightSource);
                     atten = 1 / (distance * distance);
                     lightDirection = normalize(fragmentToLightSource);
                 }
                 
                 
                 float3 diffuseReflection = atten * _LightColor0.xyz * max(0.0, dot(normalDir, lightDirection));
                 o.light = float4(diffuseReflection.rgb, 1.0);
                 o.pos = mul(UNITY_MATRIX_MVP, v.vertex);
                 
                 return o;
             }
             
             float4 frag(vertexOutput i):COLOR{
                 return i.light;
             }
             
             
             ENDCG
         }
         
         Pass{
             Tags {"LightMode" = "ForwardAdd"}
             Blend One One
             
             CGPROGRAM
             
             #pragma vertex vert
             #pragma fragment frag
             
             //user defined
             uniform float4 _Color;
             
             //Unity Defined
             uniform float4 _LightColor0;
             
             struct vertexInput{
                 float4 vertex: POSITION;
                 float3 normal: NORMAL;
             };
             
             struct vertexOutput{
                 float4 pos: SV_POSITION;
                 float4 light : TEXCOORD0;
             };
             
             
             vertexOutput vert(vertexInput v){
                 vertexOutput o;
                 
                 float4 posWorld = mul(_Object2World, v.vertex);
                 
                 float atten;
                 float3 lightDirection;
                 
                 float3 normalDir = normalize(mul(float4(v.normal,1.0), _World2Object).xyz);
                 
                 //lighting
                 if(_WorldSpaceLightPos0.w == 0.0){
                     atten = 1.0;
                     lightDirection = normalize(_WorldSpaceLightPos0.xyz);
                 
                 } else {
                     float3 fragmentToLightSource = _WorldSpaceLightPos0.xyz - posWorld.xyz;
                     float distance = length(fragmentToLightSource);
                     atten = 1 / (distance * distance);
                     lightDirection = normalize(fragmentToLightSource);
                 }
                 
                 
                 float3 diffuseReflection = atten * _LightColor0.xyz * max(0.0, dot(normalDir, lightDirection));
                 o.light = float4(diffuseReflection.rgb, 1.0);
                 o.pos = mul(UNITY_MATRIX_MVP, v.vertex);
                 
                 return o;
             }
             
             float4 frag(vertexOutput i):COLOR{
                 return i.light;
             }
             
             
             ENDCG
         }
         
         
         
     }
     FallBack "Diffuse"
 }
 

Is there anything I can do to make sure the light falls off before the light's range? Or should I just set the range to a crazy high value? Thanks for any help!

capture.png (60.7 kB)
Comment
Add comment · Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image rtrimble · Oct 11, 2015 at 11:08 PM 0
Share

Another note that when using AutoLight.cginc, LIGHT_COORDS, and LIGHT_ATTENUATION, I appear to get the same result.

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by LaurynasLubys · Oct 30, 2016 at 04:42 PM

I have the same problem with my code.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

39 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Is it possible to use an Int64 data type in CG? 0 Answers

Problem with fresnel materials 0 Answers

Storing data from previous shader pass 0 Answers

System.IO.File' does not contain a definition for `ReadAllBytes' 2 Answers

C# Newbie Programming Questions 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges