Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
1
Question by MiraiTunga · Feb 22, 2013 at 10:31 AM · efficiencyshort

Trying to achevie Shorter code less repetition

this is the code iam using but cant figure out a way to make it short

public var health = 200;

 function OnTriggerEnter(other:Collider){
 
 var ammorPls: GameObject[] = GameObject.FindGameObjectsWithTag("ammor");
     
 // Assign the builtin array to a js Array
    var ammorPlsB = new Array (ammorPls);
 
     if(other.tag=="bullet"){
         health = health-10;
     }
     
        if(health<10) {
         //remove ammor sections from range
    
            for (var a = 0; a < 3; a++) {
            
               ammorPlsB[a].rigidbody.isKinematic=false;
               ammorPlsB[a].rigidbody.useGravity=true;
               ammorPlsB[a].transform.parent = null;
               ammorPlsB[a].collider.enabled=true;
           
               }
          }
             
 
        if(health<20) {
         //remove ammor sections from range
    
            for (var b = 3; a < 6; a++) {
            
               ammorPlsB[b].rigidbody.isKinematic=false;
               ammorPlsB[b].rigidbody.useGravity=true;
               ammorPlsB[b].transform.parent = null;
               ammorPlsB[b].collider.enabled=true;
           
               }
          }      
 
 
 ......
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1

Answer by Bunny83 · Feb 22, 2013 at 10:48 AM

I would do something like:

 static function DropObject(obj : GameObject)
 {
     obj.rigidbody.isKinematic = false;
     obj.rigidbody.useGravity = true;
     obj.transform.parent = null;
     obj.collider.enabled = true;
 }
 
 function OnTriggerEnter(other:Collider)
 {
     var ammorPls: GameObject[] = GameObject.FindGameObjectsWithTag("ammor");
     var ammorPlsB = new Array (ammorPls);
     
     if(other.tag=="bullet")
     {
         health = health-10;
         var index : int = health / 10;
         index = Mathf.Clamp(index*3, 0, ammorPlsB.length-2);
         for (var a = 0; a < 3; a++) {
             DropObject(ammorPlsB[index + a])
         }
     }
 }
Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image MiraiTunga · Feb 24, 2013 at 05:58 AM 0
Share

thanks for the answer ..i can kinda see how it can wrk tried implementing it tho and had a few problems i think iam just gona do it the long way

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

10 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Script Efficiency 1 Answer

How to make code more efficient 3 Answers

How does code licensing for Unity works? What happens when I post for evaluation / showcase? 1 Answer

Instantiate as child 3 Answers

Scripting a Konami Code 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges