Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by versmesalx · Mar 17, 2016 at 07:24 PM · symbol

Hello and I need some help with coding

So I am really a beginner and I have been trying to complete the TANKS 3D tutorial to some kind get a hang of the coding and game-making in general. However, I have ran into some problems related to coding. Been working with the Tank Movement script, and although I've been completely following the tutorial (or at least I think I have) some bugs in the coding still showed up. I have been working hard to get around those but all I have managed to do was to cut to 3 bugs. Could anybody help me to fix this and provide some brief explanation? Thank you in advance.

 private void EngineAudio()
     {
         if (Mathf.Abs (m_MovementInputValue) < 0.1f && Mathf.Abs (m_MovementInputValue) < 0.1f)
 
             {
                 if (m_MovementAudio.clip == m_EngineDriving)
                 {
                     m_MovementAudio.clip = m_EngineIdling;
                     m_MovementAudio.pitch = Random.Range (m_OriginalPitch - m_PitchRange, m_OriginalPitch + m_PitchRange);
                     m_MovementAudio.Play ();
                 }
             }
 
 
 
                 else if (m_MovementAudio.clip == m_EngineIdling)
         {
             {
                     m_MovementAudio.clip = m_EngineDriving;
                     m_MovementAudio.pitch = Random.Range (m_OriginalPitch - m_PitchRange, m_OriginalPitch + m_PitchRange);
                     m_MovementAudio.Play () 
             }
             
     }

This one gives issue with the last bracket (Unexpected symbol)

 private void Move()
     {
         // Adjust the position of the tank based on the player's input.
             {    Vector3 movement = transform.forward * m_MovementInputValue * m_Speed * Time.deltaTime;
         m_Rigidbody.MovePosition (m_Rigidbody.position + movement);
 
             }
     }
 
 
     private void Turn()
     {
        
             {    float turn = m_TurnInputValue * m_TurnSpeed * Time.deltaTime;
 
         Quaternion turnRotation = Quaternion.Euler (0f, turn, 0f);
 
         m_Rigidbody.MoveRotation (m_Rigidbody.rotation * turnRotation); 
             }
     }
 }

This one has issue with the private symbol in the beggining. (Unexpected symbol 'private, though there are several other 'private ' symbols which seem to work well.

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1

Answer by Bonfi_96 · Mar 17, 2016 at 08:00 PM

In the first one there is an extra bracket before "m_MovementAudio.clip" (I made a correction considering the "else" belonging to the first if)

  private void EngineAudio()
      {
          if (Mathf.Abs (m_MovementInputValue) < 0.1f && Mathf.Abs (m_MovementInputValue) < 0.1f)
  
              {
                  if (m_MovementAudio.clip == m_EngineDriving)
                  {
                      m_MovementAudio.clip = m_EngineIdling;
                      m_MovementAudio.pitch = Random.Range (m_OriginalPitch - m_PitchRange, m_OriginalPitch + m_PitchRange);
                      m_MovementAudio.Play ();
                  }
              }
  
  
  
          else if (m_MovementAudio.clip == m_EngineIdling)
         {
              m_MovementAudio.clip = m_EngineDriving;
              m_MovementAudio.pitch = Random.Range (m_OriginalPitch - m_PitchRange, m_OriginalPitch + m_PitchRange);
              m_MovementAudio.Play () 
         }
              
      }

I the second one both functions have a pair of extra brackets, and another one to the bottom (maybe you copied the class ending bracket?)

  private void Move()
          // Adjust the position of the tank based on the player's input.
          {    Vector3 movement = transform.forward * m_MovementInputValue * m_Speed * Time.deltaTime;
          m_Rigidbody.MovePosition (m_Rigidbody.position + movement);
  
          }
 
  
  
      private void Turn()
      {
         float turn = m_TurnInputValue * m_TurnSpeed * Time.deltaTime;
  
          Quaternion turnRotation = Quaternion.Euler (0f, turn, 0f);
  
          m_Rigidbody.MoveRotation (m_Rigidbody.rotation * turnRotation); 
 
      }
 

Anyway, I would suggest you to get better at indenting the code properly, you would easily avoid this kind of isuues

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image versmesalx · Mar 20, 2016 at 08:00 AM 0
Share

Thank you for your help. Yes, I am trying to get the hang of this as quick as i can :D

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

51 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

How can I make an "aim System" for my tank game? (See where shell will land) 0 Answers

Unexpected symbol `1' ?? 1 Answer

error CS1525: Unexpected symbol `&&' How do I correct this error 2 Answers

error CS1525: Unexpected symbol `offsetX' 1 Answer

Urgent Help Error cs1525! 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges