Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
This post has been wikified, any user with enough reputation can edit it.
avatar image
0
Question by Prof123 · Feb 16, 2014 at 07:32 AM · listenemymonstersystem.collections.generic

List<> Other elements problems

 using UnityEngine;
 using System.Collections;
 [System.Serializable]
 public class pl  {
     public string name;
     public int hp,maxhp;
     public int attack;
 }
 using UnityEngine;
 using System.Collections;
 using System.Collections.Generic;
 public class player : MonoBehaviour {
     public pl[] pl;
     public List<pl> pll;
 
     void Update(){
 
     }
     void OnGUI(){
 if(GUILayout.Button("TIKLA")){
 
             pll.Add(pl[0]);
 
         }
     }
 }

Sorry for very bad english :( When I add list same item. When I change the name of the last item Change is happening as I have all of the same item I want to be independent of the items I need my monsters list.

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by Lockstep · Feb 16, 2014 at 10:12 AM

First of all: Change the names of your classes to something meaningfull. In two weeks you probably won't know which was pll and which was pl. Besides you have given the name pl twice. Once for the class and once for an array of that class. Don't do this! I rename the pl class to Monster to avoid confusion.

When you add an element to your list twice, it is still the same object. Both list places refer to the same object. Thus it is only naturally if manupulating an object from one list spot will change what you get if you look up the very same object from another list spot.

The solution is to make a clone of you object.

Cloning is something highly nontrivial. You always have to consider if you want to create a new instance of a variable or get a reference. Here is some usefull information about cloning for further reading.

In your case you can do this: Add a clone constructor to your custom class. It only uses a string and some ints so this will do. If you use other classes like the Transform class in your custom class, you should read the link above.

Add this to your Monster class

 public Monster (Monster cloneMe){
     this.name = cloneMe.name;
     //etc
 }

And then in your player class instead of the pll.Add:

 Monster newMonster = new Monster(pl[0]);
 pll.Add(newMonster);

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

19 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Removing Missing Objects From A List 1 Answer

A node in a childnode? 1 Answer

Finding enemies from a list script 1 Answer

bool[] to bool list 1 Answer

Get First Object In List 2 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges