Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by LAGamesPortfolio · Sep 17, 2014 at 12:24 PM · audiosource

Muting An Overlapping Audio Clip?

Hi Everyone!

I'm hoping that someone here can help me with a problem that I'm having. I'm trying to get back into coding in Unity and I'm having an issue with the script below. This script is being used to open and close a door and currently what is happening is when the door is closing; both the "Open Sound" and "Close Sound" is playing at the same time. Does anyone know how I can make it so that when the door is closing, only the close sound is playing?

 // Smothly open a door
 var smooth = 2.0;
 var DoorOpenAngle = 90.0;
 var open : boolean = false;
 
 var doorOpenSound : AudioClip;
 var doorCloseSound : AudioClip;
 
 @script RequireComponent(AudioSource);
 
 private var enter : boolean;
 private var defaultRot : Vector3;
 private var openRot : Vector3;
 
 function Start()
 {
     defaultRot = transform.eulerAngles;
     openRot = new Vector3 (defaultRot.x, defaultRot.y + DoorOpenAngle, defaultRot.z);
 }
 
 //Main function
 function Update ()
 {
     if(open)
     {
         //Open door
         transform.eulerAngles = Vector3.Slerp(transform.eulerAngles, openRot, Time.deltaTime * smooth);
     }
     
     else
     {
         //Close door
         transform.eulerAngles = Vector3.Slerp(transform.eulerAngles, defaultRot, Time.deltaTime * smooth);
     }
 
     if(Input.GetKeyDown("f") && enter)
     {
         open = !open;
         audio.PlayOneShot(doorOpenSound);
     }
     
     if(Input.GetKeyDown("f") && enter && !open)
     {
         audio.PlayOneShot(doorCloseSound);
     }
 }
 
 function OnGUI()
 {
     if(!open && enter)
         {
             GUI.Label(new Rect(Screen.width/2 - 75, Screen.height - 100, 150, 30), "Press 'F' to open the door");
         }
 
     if (open && enter)
         {
             GUI.Label(new Rect(Screen.width/2 - 75, Screen.height - 100, 150, 30), "Press 'F' to close the door");
         }
 }
 
 //Activate the Main function when player is near the door
 function OnTriggerEnter (other : Collider)
 {
     if (other.gameObject.tag == "Player") 
         {
             enter = true;
         }
 }
 
 //Deactivate the Main function when player is go away from door
 function OnTriggerExit (other : Collider)
 {
     if (other.gameObject.tag == "Player") 
         {
             enter = false;
         }
 }


Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by Baste · Sep 17, 2014 at 12:41 PM

You've forgotten to check if the door is closed when you play the opening sound! Here's the problem:

 if(Input.GetKeyDown("f") && enter)
 {
     open = !open;
     audio.PlayOneShot(doorOpenSound); // <== PROBLEM LINE
 }

The line marked above will be called both when the door is open and closed.

The way to fix this is to replace this:

 if(Input.GetKeyDown("f") && enter)
 {
     open = !open;
     audio.PlayOneShot(doorOpenSound);
 }
 
 if(Input.GetKeyDown("f") && enter && !open)
 {
     audio.PlayOneShot(doorCloseSound);
 }

with this:

 if(Input.GetKeyDown("f") && enter)
 {
     if(closed)
         audio.PlayOneShot(doorOpenSound);
     else
         audio.PlayOneShot(doorCloseSound);
     open = !open;
 }
Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image LAGamesPortfolio · Sep 17, 2014 at 01:21 PM 0
Share

Thanks Baste! I had to add another variable to get it to work but the code you supplied aided the solution. I'm more of an artist than a coder but I have some knowledge of coding =P

Thanks again!

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

3 People are following this question.

avatar image avatar image avatar image

Related Questions

Change variable value based on perceived audio volume 1 Answer

how is the volume of an audiosource computed? 1 Answer

AudioSource.ignoreListenerVolume ineffective? 1 Answer

How to Mute / Unmute audio after WaitForSeconds() 1 Answer

Footstep Sounds 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges