Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Darkskxcher · Nov 26, 2014 at 02:36 PM · c#switchstatementcase

What is wrong with my c# switch statement?

Hello,

I made a switch statement to control the up and down movement for a pin. The script is attached to a simple cube and everything works fine because he prints everything in the log. What I want to do is: Click the cube once and the pin starts moving, click the cube again and it stops moving.

I think I am pretty close because I can either start it or stop it depending on what I change the ' state' value to. When I keep it on 1 it starts moving onclick but doesn't stop and vice versa.

Here is my code:

 void Update ()
         {
                 if (Input.GetMouseButtonDown (0)) {
                         pinToggle ();                
                 }
         }
         
         void pinToggle ()
         {    
                 int state = 1;
                 switch (state) {
                 case 1:
                         pinmovement.pinStart = true;
                         Debug.Log ("PinStart state: " + pinmovement.pinStart);
                         break;
                 case 2:
                         pinmovement.pinStart = false;
                         Debug.Log ("PinStart2 state: " + pinmovement.pinStart);
                         break;
                 }
                 
         }

The pinmovement is another script that containts the pin code and pinStart is a boolean to control wether it has to move or not.

Comment
Add comment · Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Darkskxcher · Nov 26, 2014 at 02:06 PM 2
Share

Thank you so much, it solved my problem! I probably would never have thought of that.

1 Reply

· Add your reply
  • Sort: 
avatar image
2
Best Answer

Answer by gjf · Nov 26, 2014 at 12:51 PM

line 10 is most of your problem - if you're only ever setting it to 1, you'll only ever be setting your variable to true!

your pinToggle() method could just do this:

 void pinToggle()
 {
     if (pinmovement != null)
     {
         pinmovement.pinStart = !pinmovement.pinStart;
     }
 }


Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

3 People are following this question.

avatar image avatar image avatar image

Related Questions

Why would my switch's case be correct but the output is not? 2 Answers

Adjusting location on save to avoid infinite loop. 1 Answer

want to convert too many if statements into 1 switch case statement. error help. 2 Answers

I would like some help refactoring my code, I am working with switch cases concering the delivery of food items in my game 1 Answer

Why does only one object respond, while more objects have exact same script? 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges