Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by dreasgrech · Mar 11, 2013 at 08:44 PM · c#yieldienumeratorrefactor

Having trouble refactoring an IEnumerator method with multiple yields

The gist of my code is as follows:

 // Play the first beat
 audio.PlayOneShot(beat);
 
 // Show 1st heartbeat border flash
 TweenAlpha.Begin(heartbeatPanel.gameObject, 0.1f, currentStress);
 yield return new WaitForSeconds(0.1f);
 TweenAlpha.Begin(heartbeatPanel.gameObject, 0.5f, 0);
 
 yield return new WaitForSeconds(interval);
 
 // Play the second beat
 audio.PlayOneShot(beat);
 
 // Show 2nd heartbeat border flash
 TweenAlpha.Begin(heartbeatPanel.gameObject, 0.1f, currentStress);
 yield return new WaitForSeconds(0.1f);
 TweenAlpha.Begin(heartbeatPanel.gameObject, 0.5f, 0);
 
 yield return new WaitForSeconds(interval * 2);



Now I want to split the above code into a single IEnumerator method with 2 calls.

This is what I came up with:

 StartCoroutine(PlayBeat(currentStress, interval));
 StartCoroutine(PlayBeat(currentStress, interval * 2));

 // ...

 IEnumerator PlayBeat(float currentStress, float interval)
 {
      audio.PlayOneShot(beat);

      TweenAlpha.Begin(heartbeatPanel.gameObject, 0.1f, currentStress);
      yield return new WaitForSeconds(0.1f);
      TweenAlpha.Begin(heartbeatPanel.gameObject, 0.5f, 0);

      yield return new WaitForSeconds(interval);
 }

The problem with this is that it doesn't work, hence why I'm asking the question.

What's the best way to extract my two repetitive blocks of code above into a single IEnumerator method?

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by dreasgrech · Mar 13, 2013 at 07:19 PM

Solved it, thanks to StackOverflow.

What I was missing was yielding the Coroutine:

 yield return StartCoroutine(PlayBeat(currentStress, interval));
 yield return StartCoroutine(PlayBeat(currentStress, interval * 2));


Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

10 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

What am I doing wrong with IEnumerator? 1 Answer

Problem using yield and IEnumerator in a custom function 2 Answers

IEnumerator not working 1 Answer

Yield Wait for Seconds (A little help here) 2 Answers

Only the first half of my coroutine works 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges