Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by garmekain · Mar 17, 2016 at 03:11 PM · classesinstances

Can't load array from another class

I want to have a variable containing all game items inside the Item class, but when I try to get the value of GameItemContainer.Container.items it gives me an error.

Item.cs:

 public string Name;
 public float Price;

 // Contructors
 public Item() {}
 public Item(string itemName)
 {
     List<Item> allItems = GameItemContainer.Container.items;
     for (int i = 0; i < allItems.Count; i++) {
         if (allItems[i].Name.ToLower() == itemName.ToLower()) {
             this.Name = allItems[i].Name;
             this.Price = allItems[i].Price;
             break;
         }
     }
 }


GameItemContainer.cs:

 [XmlArray("Items"),XmlArrayItem("Item")]
 public List<Item> items = new List<Item> ();


 public static GameItemContainer Container = LoadXML("gameItems");

 private static GameItemContainer LoadXML(string xmlname) {
     return GameItemContainer.Load (Path.Combine (Application.dataPath, "Scripts/XML/" + xmlname + ".xml")) as GameItemContainer;
 }

 public static GameItemContainer Load(string path)
 {
     XmlSerializer serializer = new XmlSerializer(typeof(GameItemContainer));
     using(var stream = new FileStream(path, FileMode.Open))
     {
         return serializer.Deserialize(stream) as GameItemContainer;
     }
 }


Error appears in line

 List<Item> allItems = GameItemContainer.Container.items;

And it throws the error

 NullReferenceException: Object reference not set to an instance of an object


Any help would be greatly appreciated.

Comment
Add comment · Show 3
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Brocccoli · Mar 17, 2016 at 03:48 PM 0
Share

Have you verified that

 LoadXml("gameItems");

does not return null? I would do that first before continuing any farther. If it does return null, than you know something is wrong with your load.

Also, no need for the "as GameItemContainer" at

 return GameItemContainer.Load (Path.Combine (Application.dataPath, "Scripts/X$$anonymous$$L/" + xmlname + ".xml")) as GameItemContainer;

because your GameItemContainer.Load method has a return type of GameItemContainer.

avatar image garmekain · Mar 17, 2016 at 03:52 PM 0
Share

@Brocccoli Yes, it returns something. in another part of code I have:

     void Start() {
         print (GameStateContainer.Container.items);
     }

and it returns System.Collections.Generic.List`1[Item]

avatar image Brocccoli garmekain · Mar 17, 2016 at 03:57 PM 0
Share

That doesn't guarantee that your LoadX$$anonymous$$L method returns anything. All that is printing out is the type of the variable, which it knows because you instantiate it as an empty list.

You need to explicitly check that your LoadX$$anonymous$$L method is returning something you want and not null.

0 Replies

· Add your reply
  • Sort: 

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

51 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Is it possible to customize how a variable of a certain type would look in the inspector? 1 Answer

Cant load variable of other script from constructor 1 Answer

Access child class variable inside child class script as a parent class of the parent script 0 Answers

Calling Function from another script not working 1 Answer

Scripts unintentionally sharing data (using public classes) 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges