Monosingleton: Call a singleton method

Question

Good afternoon folks,

I'm trying to use a generict abstract class to make a MonoSingleton [example][1], but when I call a method that implements it: e.g the method DoSomething() from the class ClientManager: MonoSingleton I receive this error: MonoSingleton doesn't contain the implementation of DoSomething

How I call the method outside the singleton class:

  public void JoinTheSession()
     {
         ClientManager_2.Instance.CallServerForPrimitives();
         Close();
     }

How the method is implemented in ClientManager:

   public void CallServerForPrimitives()
     {
         _hubConnection.InvokeAsync("GetPrimitives");
     }

I also noticed that visul studio reminds me to the MonoSingleton Class when I do "Ctrl + RightClick" on the ClientManager.Instance.

Implementation of the Monosingleton:

 public abstract class MonoSingleton<T> : MonoBehaviour where T : MonoSingleton<T> 
 {
     private static MonoSingleton<T> _instance;
 
     public static MonoSingleton<T> Instance
     {
         get
         {
             if (_instance == null)
                 Debug.Log(typeof(T).ToString() + " is NULL.");
                 return _instance;
         }
     }
 
     private void Awake()
     {
         if (_instance != null && _instance != this)
         {
             Destroy(this.gameObject);
         }
         else
         {
             _instance = this as T;
         }
         Init();
     }
 
     public virtual void Init()
     {
 
     }
 }

Implementation of a script I would like to be MonoSingleton

 public class ClientManager_2 : MonoSingleton<ClientManager_2>
 {
 public int Variable;
  public void someMethod(){}
 }

Any suggestions is appreciated! Thank you :) [1]: https://gist.github.com/onevcat/6025819

MY SOLUTION:

In the Method where I want to use the Monosignleton CLientManager I do this:

 //declare a variable CleintManager:
 
 ClientManager ClientMan;
 
 // get the singleton instance
 
 ClientMan= (ClientManager) ClientManager.Instance;
 ClientMan.SomeMethod();

Answer 1

Best Answer

Answer by sacredgeometry · Apr 09, 2020 at 06:37 PM

Your MonoSingletons generic type constraint is of another MonoSingleton<T> change it to a MonoBehaviour and update all references in the singleton to T instead of MonoSingleton alt text

screenshot-2020-04-09-at-193758.jpg (510.1 kB)

Add comment · Show 7 · Share

sacredgeometry · Apr 09, 2020 at 06:49 PM 0

Share

Once you have done that storing a reference to the singletons instance (I am not sure I would though) will be as simple as creating a Client$$anonymous$$anager property or field and setting it to the Client$$anonymous$$anger.Instance then referencing it. i.e:

     Client$$anonymous$$anager Client = Client$$anonymous$$anager.Instance;
 
     void Start()
     {
         Client.Some$$anonymous$$ethod();
     }

salvolannister sacredgeometry · Apr 09, 2020 at 09:06 PM 0

Share

That's what I was looking for! Even if I don't understand exactly why it works. Anyway with your solution there is no more need to make a declaration of Client... Thank you :)

JxWolfe · Apr 09, 2020 at 06:55 PM 0

Share

he's ALREADY DECLARED HIS SOLUTION! (while I got off topic yes, the main point was for him to close the thread.)

sacredgeometry JxWolfe · Apr 09, 2020 at 06:59 PM 0

Share

His solution is a bit of a non solution. His code is a workaround to a problem he created needlessly.

JxWolfe sacredgeometry · Apr 09, 2020 at 07:01 PM 0

Share

you're not wrong. but I doubt he'd change it now.

Show more comments

Answer 2

Answer by JxWolfe · Apr 09, 2020 at 06:33 PM

yea I was going to put your solution. Looks like you already found it. (sorry for not seeing it sooner) Because all you need to get the reference to the game object (the physical script) in order to call anything that isn't static. However, as Instance is static, any script can reference it, and then they have a "link" to the physical in-game script.

I almost forgot what I was going to say. As you've solved your own issue, please close the thread.

Add comment · Show 1 · Share

sacredgeometry · Apr 09, 2020 at 06:37 PM 0

Share

Thats not why its not working

Monosingleton: Call a singleton method

2 Replies

Follow this Question

Related Questions