Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by DissonanceMask · Jan 19, 2020 at 09:49 AM · turrettargetingtower-defenseforloop

Tower Defense turret with multiple targets within range. Help with targeting and nulling.

Please take a look at my code. I set my array to a Length of 5, and I intentionally have only 3 gameobjects: a Cube, Sphere, and Capsule, each with the Shape class (inherited, but it doesnt matter). My problem with the script is, whenever a first Shape is added to the target list, and then a second one is added, then the first one is nulled due to out of range, the second Shape will occupy the null element above it.

Im sure itis about the for loop, but I am unsure of how to prevent a Shape from entering the target array more than once. Here is the code:

 public class TarGetter : MonoBehaviour
 {
     private const string TARGETING_GETTER = "Target Getter";
     [SerializeField] float targetRad;
     int targetAllowed = 5;
     [SerializeField] Shape[] target;    
     private void Awake()
     {
         gameObject.name = TARGETING_GETTER;
     }
 
     void Start()
     {
         target = new Shape[targetAllowed];
         //InvokeRepeating("UpdateTargets", 0f, 0.5f);
     }
 
     private void Update()
     {
         UpdateTargets();
     }
 
     void UpdateTargets()
     {
         Shape[] targetables = FindObjectsOfType<Shape>();
         foreach(Shape t in targetables)
         {            
             float targDist = Vector3.Distance(transform.position, t.transform.position);
             for (int i = 0; i < target.Length; i++)
             {              
                 if (targDist <= targetRad && target[i] == null)
                 {
                     target[i] = t;
                     break;
                 }
                 else if (targDist <= targetRad)
                 {
 
                 }
                 else if (targDist <= targetRad && target[i] != t)
                 {
                     continue;
                 }
                 else if (targDist <= targetRad && target[i] == t)
                 {
                     break;
                 }
                 else if (targDist > targetRad && target[i] == t)
                 {
                     target[i] = null;
                     break;
                 }
             }
         }
     }
 
     private void OnDrawGizmos()
     {
         Gizmos.color = Color.red;
         Gizmos.DrawWireSphere(transform.position, targetRad);
     }
 
 
 }

Comment
Add comment · Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image DissonanceMask · Jan 19, 2020 at 11:47 AM 0
Share

Disregard the empty else if statement

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by Nightylion · Jan 20, 2020 at 12:22 PM

Shapes actually shouldn't be able to enter in list twice, since you use foreach(). Every shape will do only 1 iteration.

I am not sure where the problem is, but try change your for() loop to something like that:

 for (int i = 0; i < target.Length; i++)
     if (target[i] == null)    //add this
              {              
                  if (targDist <= targetRad && target[i] == null)
                  {
                      target[i] = t;
                      //break;
                  }
                  else if (targDist <= targetRad)
                  {
  
                  }
                  else if (targDist <= targetRad && target[i] != t)
                  {
                      continue;
                  }
                  else if (targDist <= targetRad && target[i] == t)
                  {
                      //break;
                  }
                  else if (targDist > targetRad && target[i] == t)
                  {
                      target[i] = null;
                      //break;
                  }
                  break;    //add this
              }

With this every shape will operate with just first nulled position in your array.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

118 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Turret shooting arrows? 1 Answer

[Solved]How to destroy a turret in Tower Defense game 2 Answers

Is there a way to use a WireSphere instead of a trigger collider to get targets. 1 Answer

Turret A.I scripts 1 Answer

How do i predict the position of my player for the turret to shoot at? 2 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges