All Units Go to Same Waypoint

Question

I create a certain number of Objects (primitive spheres in my test), and I place them at random locations on a terrain. They are instantiated objects in a Custom Class. I have it coded so that if I click the primitive sphere, it turns from Blue to Cyan, and then I click on a location on my terrain it adds that location to a waypoint list (vector3 list that is part of the custom class). The sphere will then move from point to point on the waypoint list. And everything works like magic -- as long as I have only ONE sphere on the terrain. If I have more than one, they all go to the same waypoints. I'm having a hard time figuring out where I'm going wrong. Hmmmm. I'd greatly appreciate it if someone might take a peek and point out to me my error. Thanks.

Here's my Custom Class:

 public class UnitSphere
 {
     public string uName{ get; set; }
     public float uStrength{ get; set; }
 
     public List<Vector3> waypoint { get; set; } 
     public UnitSphere()
     {
         waypoint = new List<Vector3> (); 
     }
 
     public UnitSphere(string name, float strength)
     {
         uName = name;
         uStrength = strength;
     }
 }

Heres' where I intiate the prefabs -- I don't think the problem is here.

     void Start ()  
     {
         Random.InitState ((int)System.DateTime.Now.Ticks); // Makes things more random
 
         for (int i = 0; i < totalUnits; i++)  
         {
             GameObject cloneGameUnit = Instantiate (GameUnit);
             cloneGameUnit.transform.position = new Vector3 (Random.Range (5f, 45f), .5f, Random.Range (5f, 45f));
             cloneGameUnit.gameObject.GetComponent<Renderer> ().material.color = Color.blue;
             string tempString = i.ToString ();
             string tempName = tempString + tempString + tempString + tempString + tempString;
             float tempStrength = Random.Range (80f, 95f);
             unit.Add(new UnitSphere(tempName,tempStrength));
         }
     }

Here's movement, works if there is only one sphere -- I think the problem is here ???

         GameObject[] fooThree;
         fooThree = GameObject.FindGameObjectsWithTag ("Friendly");
         tempIndex = 0;
         foreach (GameObject twit in fooThree)  
         {
             if (unit[tempIndex].waypoint==null){unit [tempIndex].waypoint = new List<Vector3> ();}
 
             if (unit[tempIndex].waypoint.Count > 0)  
             {
                 agent.destination = unit[tempIndex].waypoint[0];
                 agent.speed = 3.5f;
             }
             else
             {
                 agent.speed = 0;
             }
 
             if (unit[tempIndex].waypoint.Count > 0 && agent.remainingDistance < 0.5f) {unit [tempIndex].waypoint.RemoveAt(0);}
             tempIndex++;
         }

And here is adding the waypoints to the list -- Right click for single waypoint --- shift/right for multi-waypoints.

         if (Input.GetKey (KeyCode.LeftShift))   
         {
             shiftIsPressed = true;
         } 
         else  
         {
             shiftIsPressed = false;
         }
 
         if (Input.GetMouseButtonDown (1) && isSelected == true && shiftIsPressed == true)  // left shift, right mouse, object == cyan --- for adding multiple waypoints
         {
             Ray ray = Camera.main.ScreenPointToRay (Input.mousePosition);
             RaycastHit hit;
 
             if (Physics.Raycast (ray, out hit))  
             {
                 Collider col = hit.collider;
 
                 if (col.gameObject.tag == "Terrain")  
                 {
                     Debug.Log (hit.point);
 
                     GameObject[] fooOne;
                     fooOne = GameObject.FindGameObjectsWithTag ("Friendly");
                     tempIndex = 0;
                     foreach (GameObject twit in fooOne)  
                     {
                         if (twit.GetComponent<Renderer>().material.color==Color.cyan)   
                         {
                             indexNumber = tempIndex;
                             unit[indexNumber].waypoint.Add(hit.point);
                         }
                         tempIndex++;
                     }
                 }
             }
         }
         else if (Input.GetMouseButtonDown (1) && isSelected == true && shiftIsPressed == false)  // right click plus unit == cyan, --- clears waypoints and adds one new waypoint
         {
             Ray ray = Camera.main.ScreenPointToRay (Input.mousePosition);
             RaycastHit hit;
 
             if (Physics.Raycast (ray, out hit))  
             {
                 Collider col = hit.collider;
 
                 if (col.gameObject.tag == "Terrain")  
                 {
                     Debug.Log (hit.point);
 
                     GameObject[] fooOne;
                     fooOne = GameObject.FindGameObjectsWithTag ("Friendly");
                     tempIndex = 0;
                     foreach (GameObject twit in fooOne)  
                     {
                         if (twit.GetComponent<Renderer>().material.color==Color.cyan)   
                         {
                             indexNumber = tempIndex;
                             unit[indexNumber].waypoint.Clear();
                             unit[indexNumber].waypoint.Add(hit.point);
                             ResetAll ();
                         }
                         tempIndex++;
                     }
                 }
             }
         }
 
         if (Input.GetKeyUp(KeyCode.LeftShift))  
         {
             ResetAll ();
         }


     void ResetAll()
     {
         GameObject[] fooTwo;
         fooTwo = GameObject.FindGameObjectsWithTag ("Friendly");
         tempIndex = 0;
         foreach (GameObject twit in fooTwo)  
         {
             twit.GetComponent<Renderer> ().material.color = Color.blue;
             isSelected = false;
         }
     }

Answer 1

@Topthink, as a response to your interest in learning a different approach, here is what I would do to control the agents.
If I understood it correctly, the functionality you want is to be able to select each unit, assign it one or more waypoints, and let each unit follow through its list until the. As each unit is independent, they can be modelled with independent instances of a class that gets updated - a perfect candidate for a script (that is, a class derived of MonoBehaviour)!
When I think of classes, I think about what data and behaviour belongs into it, and what kind of "orders" should be possible to give them. For example, UnitSphere should know what its waypoints are, should update where it should move and move itself, and it should be possible to add a new waypoint or clear all waypoints and set a new one, as well as change its color when it is selected. From this, you can create the following class:

 using System.Collections.Generic;
 using UnityEngine;
 using UnityEngine.AI;
 
 public class UnitSphere : MonoBehaviour {
 
     private List<Vector3> waypoints = new List<Vector3>();
 
     private Renderer ownRenderer;
     private NavMeshAgent agent;
 
     private void Awake () {
         ownRenderer = GetComponent<Renderer>();
         agent = GetComponent<NavMeshAgent>();
 
         SetSelected(false);
     }
 
     private void Update () {
         // if arrived at first waypoint, remove it
         if (waypoints.Count > 0 && !agent.isStopped && agent.remainingDistance < 0.5f) {
             waypoints.RemoveAt(0);
         }
 
         if (waypoints.Count > 0) {
             // if the first waypoint changed...
             if (waypoints[0] != agent.destination) {
                 // set as new destination
                 agent.destination = waypoints[0];
                 // make sure to start agent
                 agent.isStopped = false;
             }
         }
         // if there is no waypoint, stop
         else { agent.isStopped = true; }
     }
 
     public void AddWaypoint (Vector3 newPoint) {
         waypoints.Add(newPoint);
     }
 
     public void SetWaypoint (Vector3 newPoint) {
         waypoints.Clear();
         waypoints.Add(newPoint);
     }
 
     public void SetSelected (bool value) {
         // this is the same as "if (value) { ...color = Color.cyan; } else { ...color = Color.blue; }"
         ownRenderer.material.color = value ? Color.cyan : Color.blue;
     }
 
 }

The rest of the functionality simply doesn't belong into UnitSphere, because it is user input. What is the rest of the functionality? Creating the units, being able to select and unselect them, add a waypoint, and set a new waypoint. Here it goes:

 using UnityEngine;
 
 public class UnitInput : MonoBehaviour {
 
     [SerializeField] private int numUnits = 10;
 
     [SerializeField] UnitSphere unitSpherePrefab = null;
 
     private UnitSphere selectedUnit;
 
     private void Start () {
         for (int i = 0; i < numUnits; ++i) {
             // you can directly assign a position when instantiating
             Vector3 position = new Vector3(Random.Range(5f, 45f), .5f, Random.Range(5f, 45f));
             // you can directly create a game object and get a reference to a script on it
             UnitSphere unitSphereInstance = Instantiate(unitSpherePrefab, position, Quaternion.identity);
             // every script has a game object, and every game object has a name
             unitSphereInstance.name = i.ToString();
             // unitSphereInstance.SetSelected(false); // we could call this here, but this initialization doesn't really belong here
         }
     }
 
     private void Update () {
         // on right click...
         if (Input.GetMouseButtonDown(1)) {
             RaycastHit hit;
             // this is an easier way of creating a ray from mouse click
             if (Physics.Raycast(Camera.main.ScreenPointToRay(Input.mousePosition), out hit)) {
                 // instead of checking tag, get the script directly
                 UnitSphere unitClicked = hit.collider.GetComponent<UnitSphere>();
                 if (unitClicked != null) {
                     // change selection, wrapped into a function
                     SelectUnit(unitClicked);
                 }
                 // clicked on something else; you might want to check if it is terrain
                 else {
                     // if there is a unit selected...
                     if (selectedUnit != null) {
                         if (Input.GetKey(KeyCode.LeftShift)) {
                             selectedUnit.AddWaypoint(hit.point);
                         }
                         else {
                             selectedUnit.SetWaypoint(hit.point);
                             // unselect as you do in your example; 
                             // however, it would be better to have selection/unselection on a different button!
                             SelectUnit(null);
                         }
                     }
                 }
             }
         }
     }
 
     private void SelectUnit (UnitSphere newUnitSphere) {
         if (selectedUnit != null) { selectedUnit.SetSelected(false); }
         selectedUnit = newUnitSphere;
         if (selectedUnit != null) { selectedUnit.SetSelected(true); }
     }
 
 }

You might also notice that I wrapped things that belong together into separate functions, for example in case of SelectUnit(). Note how it handles all the possibilities, first unselecting the currently selected unit, no matter what, and then selecting the new one, but only if it wasn't null.
Any question you might have, feel free to ask!

All Units Go to Same Waypoint

1 Reply

Your answer

Follow this Question

Related Questions