Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by maldia · Dec 21, 2020 at 10:03 AM · startcoroutine

How can i get my Coroutine to work every time my player takes damage?

Hey there, noob here!

Im looking to make my player blink/flash on and off when it collides with an enemy. I managed to make the coroutine work but it only works on the initial collision with an enemy but it doesn’t work again after the second or third hit. The player does take damage, the health does go down as expected but the blinking does not. This is my code so far;

This is from my Player script:

 public void Damage()
     {
         health -= damage;
 
         if (health <= 0)
         {
             health = 100;
             lives--;
 
             if (lives == 0)
             {
                 Destroy(this.gameObject);
             }
         }
     }
 
     public IEnumerator BlinkingPlayerDamage()
     {
         Color color = spriteRenderer.color;
 
         while (blinkTimer != blinkLength)
         {
             blinkTimer++;
 
             color.a = 0.5f;
             spriteRenderer.color = color;
             yield return new WaitForSeconds(0.1f);
 
             color.a = 1f;
             spriteRenderer.color = color;
             yield return new WaitForSeconds(0.1f);
         }
     }
 }

This is from my Enemy script:

     private void OnTriggerEnter2D(Collider2D other)
     {
         if (other.CompareTag("Player"))
         {
             Player player = other.transform.GetComponent<Player>();
 
             //deals damamge when collision with with player occurs
             if (player != null)
             {
                 player.Damage();
                 player.StartCoroutine(player.BlinkingPlayerDamage());
             }
 
             Destroy(gameObject); //destroys enemy after collision
         }
     }
 }

Ive tried setting a blinkActive bool to help and starting the coroutine from the damage method on the player Script but i still doesnt loop with every damage.

please help!

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by Llama_w_2Ls · Dec 21, 2020 at 04:50 PM

This code here might be the issue:

          while (blinkTimer != blinkLength)
          {
              blinkTimer++;
              //...
           }

Are you resetting blinkTimer every time you run the coroutine. If not, the while loop will just break immediately from the last run, since blinkTimer is still equal to blinkLength from the first run. @maldia

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image maldia · Dec 26, 2020 at 01:31 PM 0
Share

omg! I just fixed it.. I feel so dumb. thank you sooo much! you're the best!

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

110 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Brain exploding ... Problem with an internal Coroutine manager 3 Answers

IEnumerator stops at yield 1 Answer

Custom fixed update cycle? 6 Answers

Using WaitForSeconds and trigger 1 Answer

Item duration doesn't stack 3 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges