Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Maczug · Dec 18, 2019 at 10:33 PM · programmingcontrolspattern

Best Practices for switching player control logic

Hi all,

I'm working on 3D platform game where player will be able to moving object, jumping, climbing and use vehicles, etc.
Currently I'm looking for good idea for switching player control logic depending on the player state.

e.g.

  • normal state - player can walk in any direction (forward or back and rotate around) by gamepad joystick,

  • climbing state - player can move up/down or move left/right along the wall.

    Currently I have three ideas (not sure if any of them is the right one)


  • switch statement in all MonoBehaviour methods (e.g. Update, FixedUpdate, OnCollisionEnter...) - looks ugly,

  • simple interface for logic object and call current in all used MonoBehaviour methods - looks better but there is the risk I will have to create interface with all MonoBehaviour methods,

  • MonoBehaviour which will enable/disable MonoBehaviours whith state logic - player object could looks ugly in editor with a lot of attached scripts.


Which do you use or do you have better idea for it?

Thanks in advance

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by Xamtox · Dec 19, 2019 at 08:15 AM

It looks like normal State Machine: player can be in one state at the time - either climbing or walking, but not both simultaneously.

  • Switch statements will quickly become a nightmare. Better avoid any logic with switches.

  • MonoBehaviours in fact looks ugly and introduces additional work with attaching and configuring them. Why would you need MonoBehaviours with 'enable'/'disable' flag if you could do the same with pure classes and switch between them?


The trick here is to encapsulate all logic inside the state and implement state transitions.

I'd create a pure class (no reason for it to become Monobehaviour) which contain state logic (Update, FixedUpdate, ...) or even separate classes for each method (if they will become large enough - to support SRP principle of SOLID. Wrapping them with interfaces (as you mentioned) seems like nice addition.

Well, those classes could be ScriptableObjects, for flexibility and easy configuration (you could combine separate pieces of logic via inspector in endless combinations), but that depends on your needs.

Then I'd create StateController - either pure class or ScriptableObject which will contain transitions between states, eg:

 interface IStateController {
     void SwitchState(int newStateId);
     IState CurrentState();
     or
     IState GetState(int stateId);
 }

So your MonoBehaviour will become simple data and links holder, which calls required state/logic when the event occured:

 IStateController.CurrentState().UpdateLogic().Invoke(...);
 or
 IStateController.CurrentState().Update(...);

You will easily modify monobehaviour, Controller or any piece of logic because those classes are separate and simple, and that system is easily expandable.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

131 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Multiple Cars not working 1 Answer

Why is ECS better than actual Unity Entity-Component pattern ? 1 Answer

How long do movement controls take? 2 Answers

Implementing speed boosts in a flight game 1 Answer

Should I read variables serveral times, or store as temporary variable? 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges