Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by PolyNeXx · Feb 15, 2018 at 11:10 PM · c#freezingstackoverflow

Unity freezing??

i was creating a void to add objects to an inventory however i got the error StackOverflowException. i only got the error then it just froze? can anyone help + is there any neater way of doing it? Thanks

void AddToInventory() {

     Inventory inventoryLoc = inventory.GetComponent<Inventory>();
     ObjectStats objectStats  = Cast.collider.gameObject.GetComponent<ObjectStats>();

     int notAvalible = 0;
     int i = 0;

     print("Test");

     if (i != 36)
     {

         print("Pass");

         if (inventoryLoc.inventorySpace[i].Avalible == false)
         {

             Debug.Log(i);
             notAvalible += 1;

             Image logo = inventorylocation.transform.GetChild(i).Find("ImageLayer").GetComponent<Image>();

             logo.sprite = objectStats.icon;


             inventoryLoc.inventorySpace[i].Avalible = true;
             inventoryLoc.inventorySpace[i].Name = objectStats.name;
             inventoryLoc.inventorySpace[i].Icon = objectStats.icon;

         }
         else
         {
             if (i == 36)
             {
                 AddToInventory();
             }
             else
             {
                 AddToInventory();
                 i += 1;
             }
         }
     }
     

 }

The Whole Script

using System.Collections; using UnityEngine.UI; using UnityEngine; using UnityStandardAssets.Characters.FirstPerson;

public class Player : MonoBehaviour {

 //VARIBLES

 private RaycastHit Cast;
 private bool ObjectsInGame;

 public string PickupKey = "f";

 public string OpenInv = "e";
 public GameObject inventory;
 public GameObject inventorylocation;

 private float hunger, thirst, heath;

 float hungerDecrease, thirstDecrease, healthDecrease;

 float decrease = .1f;
 float decrease2 = .2f;
 float decrase3 = .3f;

 public Text hunderTxt;
 public Text thirstTxt;
 public Text HealthTxt;

 public GameObject HealthBar;
 public GameObject ThirstBar;
 public GameObject HungerBar;

 private bool Starving;
 private bool Dehydrated;
 public bool InvOpen = false;

 //private bool staiminaloss = RigidbodyFirstPersonController.mRunning;

 //FUNCTIONS

 void Start()
 {

     Inventory inventoryLoc = inventory.GetComponent<Inventory>();
     ObjectStats objectStats = Cast.collider.gameObject.GetComponent<ObjectStats>();

     heath = 70;
     hunger = 40;
     thirst = 80;

 }

 public void Update()
 {

     int HealthInt = (int)heath;
     int HungerInt = (int)hunger;
     int ThirstInt = (int)thirst;

     hunderTxt.text = HungerInt.ToString();
     thirstTxt.text = ThirstInt.ToString();
     HealthTxt.text = HealthInt.ToString();


     var HealthBarSize = HealthBar.transform as RectTransform;
     var HungerBarSize = HungerBar.transform as RectTransform;
     var ThirstBarSize = ThirstBar.transform as RectTransform;

     HealthBarSize.sizeDelta = new Vector2(HealthInt * 2, HealthBarSize.sizeDelta.y);
     HungerBarSize.sizeDelta = new Vector2(HungerInt * 2, HungerBarSize.sizeDelta.y);
     ThirstBarSize.sizeDelta = new Vector2(ThirstInt * 2, ThirstBarSize.sizeDelta.y);

     HungerAndThirst();

     if (heath <= 0)
         Die();


     if (Input.GetKeyDown(OpenInv))
     {


         if (InvOpen == true)
         {
             inventory.SetActive(false);
             InvOpen = false;

             return;
         }
         else if (InvOpen == false)
         {
             inventory.SetActive(true);
             InvOpen = true;

            
         }

     }




     if (GameObject.FindGameObjectsWithTag("Object").Length > 0)
     {
         ObjectsInGame = true;
     }
     else
     {
         ObjectsInGame = false;
     }


     Ray ray = Camera.main.ScreenPointToRay(Input.mousePosition);

     if (ObjectsInGame)
     {
         if (Physics.Raycast(ray))
         {
             if (Physics.Raycast(ray, out Cast))
             {

                 if (Cast.collider.tag == "Object")
                 {

                     if (Input.GetKeyDown(PickupKey))
                     {
                         PickupObject();
                     }
                 }
             }
         }
     }
     else
     {
         return;
     }

 }

 void PickupObject()
 {

     Destroy(Cast.collider.gameObject);

     AddToInventory();

 }

 void AddToInventory()
 {

     Inventory inventoryLoc = inventory.GetComponent<Inventory>();
     ObjectStats objectStats  = Cast.collider.gameObject.GetComponent<ObjectStats>();

     int notAvalible = 0;
     int i = 0;

     print("Test");

     if (i != 36)
     {

         print("Pass");

         if (inventoryLoc.inventorySpace[i].Avalible == false)
         {

             Debug.Log(i);
             notAvalible += 1;

             Image logo = inventorylocation.transform.GetChild(i).Find("ImageLayer").GetComponent<Image>();

             logo.sprite = objectStats.icon;


             inventoryLoc.inventorySpace[i].Avalible = true;
             inventoryLoc.inventorySpace[i].Name = objectStats.name;
             inventoryLoc.inventorySpace[i].Icon = objectStats.icon;

         }
         else
         {
             if (i == 36)
             {
                 AddToInventory();
             }
             else
             {
                 AddToInventory();
                 i += 1;
             }
         }
     }
     

 }

 public void HungerAndThirst()
 {

     int HungerInt = (int)hunger;
     int ThirstInt = (int)thirst;

     if (gameObject.GetComponent<RigidbodyFirstPersonController>().Running)
     {
         hunger -= decrase3 * Time.deltaTime;
     }
     else
     {
          hunger -= decrease * Time.deltaTime;
     }


     thirst -= decrease2  * Time.deltaTime;

     if(HungerInt <= 80 && Starving == true)
     {
         if (hunger <= 0)
         {
             Starving = true;
             print("Starve");
             heathDecrease();
         }
         print("Hunger");
         heathDecrease();
     }

     if (thirst <= 25 && !Dehydrated)
     {
         if (ThirstInt == 0)
         {
             Dehydrated = true;
             print("Dehydrate");
         }


         heathDecrease();
     }



 }

 void heathDecrease()
 {
     heath -= decrase3 * Time.deltaTime;
 }


 public void Die()
 {
     Debug.Log("Player Died");
     hungerDecrease = 0;
     healthDecrease = 0;
     thirstDecrease = 0;
 }


}

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

2 Replies

· Add your reply
  • Sort: 
avatar image
1

Answer by Harinezumi · Feb 16, 2018 at 08:11 AM

You have infinite recursion in AddToInventory(), so you reach maximum stack size (that's what StackOverflowException means).
More specifically when the expression if (inventoryLoc.inventorySpace[i].Avalible == false) is false (so Available is true), you recursively call AddToInventory() on both branches. You increase i in the hope that it will reach 36, but i is a local variable to each call of AddToInventory(), so in the recursive call it will be 0 again, and it will again call AddToInventory, forever (or until you run out of stack).

Proposed solution is to make your i variable either a member variable, or (better) pass it to the AddToInventory() function as parameter.

In general, when Unity freezes on execution of new code, it is usually an infinite loop, either with for / while loops or with a recursion of some sort.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
0

Answer by PolyNeXx · Feb 16, 2018 at 11:15 AM

Thanks, I think one of the main cause was i was calling the AddToInventory before add to i so it looped.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

497 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

How can I fix UnityEngine.Random.Range (Int32 min, Int32 max) Stack Overflow 0 Answers

StackOverflow on Instantiate 1 Answer

StackOverflow Problem when consistently checking a gameObject 1 Answer

What is the most efficient way to spawn in a lot of cubes, like 10k? [c#] 2 Answers

StackOverflowException, cant find out how to fix it 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges