Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by AlexDaGod · Apr 27, 2019 at 07:21 AM · scripting problem2d-platformer2d-physics2d animationcrouch

Managed to get my character to stay crouched when he has a ceiling over head. Problem is he remains crouched.

 using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
 
 public class PlayerMovementController : MonoBehaviour
 {
     public float maxSpeed = 10f;
     bool facingRight = true;
 
     Animator anim;
 
     bool grounded = false;
     public Transform groundCheck;
     float groundRadius = 0.2f;
     public LayerMask whatIsGround;
     public float jumpForce = 0f;
 
     bool isCrouching = false;
     public float colliderCrouch = 0f;
     public float colliderStand = 0f;
 
     bool ceiling;
     public Transform ceilingCheck;
     float ceilingRadius = 0.2f;
     public LayerMask whatIsCeiling;
     
 
 
     // Start is called before the first frame update
     void Start()
     {
         anim = GetComponent<Animator>();
         
     }
 
     // Update is called once per frame
     void Update()
     {
 
         if(grounded && Input.GetButtonDown("Jump"))
         {
             anim.SetBool("Ground", false);
             GetComponent<Rigidbody2D>().AddForce(new Vector2(0, jumpForce));
         }
         
         //On button press player BoxCollider2D is reduced by float colliderCrouch
         if (grounded && Input.GetButtonDown("Crouch"))
         {
 
             GetComponent<BoxCollider2D>().size = new Vector2(0.2193601f, colliderCrouch);
             GetComponent<BoxCollider2D>().offset = new Vector2(0, -.25f);
             isCrouching = true;
         }
 
         //On button release player BoxCollider2D enlarges by float colliderStand 
 
 
         if (!ceiling && Input.GetButtonUp("Crouch"))
         {
             
             GetComponent<BoxCollider2D>().size = new Vector2(0.2193601f, colliderCrouch);
             GetComponent<BoxCollider2D>().offset = new Vector2(0, -.25f);
             isCrouching = false;
         }
 
 
         //If the GameObject is not crouching, send that the Boolean “Crouch” is false to the Animator. The crouch animation does not play.
         if (isCrouching == false)
             anim.SetBool("Crouch", false);
 
         //The GameObject is crouching, so send the Boolean as enabled to the Animator. The crouch animation plays.
         if (isCrouching == true)
             anim.SetBool("Crouch", true);
 
     }
 
     void FixedUpdate()
     {
         grounded = Physics2D.OverlapCircle(groundCheck.position, groundRadius, whatIsGround);
         anim.SetBool("Ground", grounded);
 
         ceiling = Physics2D.OverlapCircle(ceilingCheck.position, ceilingRadius, whatIsCeiling);
         anim.SetBool("Ceil", ceiling);
 
 
         anim.SetFloat("vSpeed", GetComponent<Rigidbody2D>().velocity.y);
 
         float move = Input.GetAxis("Horizontal");
 
         anim.SetFloat("Speed", Mathf.Abs(move));
         GetComponent<Rigidbody2D>().velocity = new Vector2(move * maxSpeed, GetComponent<Rigidbody2D>().velocity.y);
 
         if (move > 0 &&!facingRight)
             Flip();
 
         else if (move < 0 && facingRight)
             Flip();
     }
     void Flip()
     {
         facingRight = !facingRight;
         Vector3 theScale = transform.localScale;
         theScale.x *= -1;
         transform.localScale = theScale;
     }
     
     
 }
 
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by JDelekto · Apr 27, 2019 at 09:06 AM

Do you realize that in the case where you are grounded and the user is pressing the "Crouch" button and the case where there is no ceiling and you are releasing the crouch button, that you are setting the size and offset of the collider to the same values, specifically:

          GetComponent<BoxCollider2D>().size = new Vector2(0.2193601f, colliderCrouch);
          GetComponent<BoxCollider2D>().offset = new Vector2(0, -.25f);

I assume because you don't reset the collider properly, your Physics2D.OverlapCircle() check is not able to reset your ceiling variable.

Also, just as a side note, you can simplify your code a bit in places, for example, where you trigger your animation.

          if (isCrouching == false)
              anim.SetBool("Crouch", false);
  
          if (isCrouching == true)
              anim.SetBool("Crouch", true);

can be distilled down to anim.SetBool("Crouch", isCrouching); which I would find much easier to read.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

118 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Make an NPC follow player on collision, ala Yoshi collecting eggs. 1 Answer

Jumping isn't smooth while going up 1 Answer

How to flip 2d character walk movement? 3 Answers

Using animated transform to push object away? 2D 0 Answers

Local scale flip is breaking rotation 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges