Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by IgorIkkun · Dec 23, 2015 at 04:32 PM · animationunity 5javascript

Animation doesn't work

I have a lamp and a character, the lamp starts on and the character in idle, i want to do this: when i click the lamp it turns off and the character starts the "lying down" animation, when i click it again the lamp turns on and the character starts the "waking up" animation. I tried to use RaycastHit and OnMouseOver function, but it doesn't work. The following javascript controls the character.

 #pragma strict
 
 var anim: Animator;
 
 function Start () {
     anim = GetComponent(Animator);
     anim.Play("Idle",-1,0f);
 }
 
 function Update () {
 if (lamp.click == true){
     anim.Play("Lying_Down",-1,0f);
 }
 
 if(lamp.click == false){
     anim.Play("Waking_Up",-1,0f);
 }
 }

The following javascript controls the lamp.

 #pragma strict

 var myLight : Light;
 static var click : boolean;
 
 function Start () {
         myLight = GetComponent(Light);
         click = false;
 }
 
 function OnMouseOver () {
 if(Input.GetButtonDown("Fire1"))
     {
         myLight.enabled = !myLight.enabled; 
         click = true;
 }
 else{
 click = false;
 }
 }
   
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by Kali2048 · Dec 24, 2015 at 02:48 AM

Make sure your lamp has a collider.

The problem with your code is that you're checking the Lamp boolean every frame and force-playing the character anim every frame.

Here is how I would do it using Events, the character register to the lamp switch event then get notified when the lamp change state, this way we only play the character animation once for every switch. This is C# but should be easy to do in Javascript.

Lamp class to be attached to the lamp object : using UnityEngine; using System.Collections;

 public class Lamp : MonoBehaviour
 {
     public delegate void LampSwitchEvent(GameObject g);
     public event LampSwitchEvent lampSwitch;
 
     private Light myLight;
 
     public bool isLampOn
     {
         get
         {
             return myLight.enabled;
         }
     }
  
     void Start ()
     {
         myLight = GetComponentInChildren<Light>();
     }
  
     void OnMouseDown ()
     {
         myLight.enabled = !myLight.enabled;
         lampSwitch(gameObject);
     }
 }



Character class to be attached to your animated character :

 using UnityEngine;
 using System.Collections;
 
 public class Character : MonoBehaviour
 {
     public Lamp myLamp; // to be assigned in unity, drop your lamp object here
 
     private Animation anim;
  
     private void HandleLampSwitch(GameObject g)
     {
         Lamp lamp = g.GetComponent<Lamp>();
 
         if (lamp.isLampOn)
         {
             Debug.Log("Lamp is on, waking up");
             anim.Play("Waking_Up");
             anim.PlayQueued("Idle");
         }
         else
         {
             Debug.Log("Lamp is off, Lying down");
             anim.Play("Lying_Down");
         }
     }
 
     void Start ()
     {
         anim = GetComponent<Animation>();
         anim.Play("Idle");
     }
 
     void Awake ()
     {
         myLamp.lampSwitch += HandleLampSwitch;
     }
 
     void Destroy()
     {
         myLamp.lampSwitch -= HandleLampSwitch;
     }
 }
 

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image IgorIkkun · Dec 24, 2015 at 03:05 AM 0
Share

It has a collider

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

58 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Need help with automatic weapon firing! 2 Answers

OnCollisonEnter2D Not Firing after checking collider 1 Answer

Walk animation wont play but idle will 0 Answers

Blender Models aren't generating mesh colliders! 0 Answers

C # script taking values from one object and modifying another. 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges