Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by BrandonKirkley · Sep 15, 2019 at 09:09 PM · listoptimizationefficiencyoptimizeefficient

How to optimize this extremely repetitive list script?

Hi! I've made a script that has a list and checks what numbers are in what place inside of it. If a certain number is in a certain slot, it activates a gameobject assigned to that number, and the placement depends on which slot it is.

The script works, but it is horribly inefficient right now. I've put in 4 gameobjects but I plan to add far more, and at this rate it would take way too much time.

I am just a beginner coder; I was wondering, how do I make this code less bulky? I can tell there's a LOT of repetition in it, but I don't know how to make it.....not repetitive.

If someone could give me a tip, I would appreciate it so much! Thank you for reading. Here is the code:

 using System;
 using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
 using UnityEngine.UI;
 
 public class numberlist : MonoBehaviour
 {
 
     public static float THESEARETHENECESSARYSTARTINGFILLERSFORTHESLOTS;
 
     private Vector3 THESEARETHECOORDINATESOFSLOTONE = new Vector3(180, 700, 0);
     private Vector3 THESEARETHECOORDINATESOFSLOTTWO = new Vector3(520, 700, 0);
     private Vector3 THESEARETHECOORDINATESOFSLOTTHREE = new Vector3(850, 700, 0);
 
     public static float THISISTHELITERALSLOTONE;
     public static float THISISTHELITERALSLOTTWO;
     public static float THISISTHELITERALSLOTTHREE;
 
     public static GameObject ALICEstaysuplateoften;
     public static GameObject ALICElikestheearlymorning;
     public static GameObject PETERisscaredofsylvia;
     public static GameObject PETERisscaredofeverything;
 
     public static List<float> THISISTHEACTUALLIST = new List<float>();
 
     void Start()
     {
         THESEARETHENECESSARYSTARTINGFILLERSFORTHESLOTS = 0;
         THISISTHEACTUALLIST.Add(THESEARETHENECESSARYSTARTINGFILLERSFORTHESLOTS);
         THISISTHEACTUALLIST.Add(THESEARETHENECESSARYSTARTINGFILLERSFORTHESLOTS);
         THISISTHEACTUALLIST.Add(THESEARETHENECESSARYSTARTINGFILLERSFORTHESLOTS);
         ALICEstaysuplateoften = GameObject.Find("ALICE stay up late");
         ALICEstaysuplateoften.SetActive(false);
         ALICElikestheearlymorning = GameObject.Find("ALICE sunrise birds");
         ALICElikestheearlymorning.SetActive(false);
         PETERisscaredofsylvia = GameObject.Find("PETER is scared of sylvia");
         PETERisscaredofsylvia.SetActive(false);
         PETERisscaredofeverything = GameObject.Find("PETER is scared of everything");
         PETERisscaredofeverything.SetActive(false);
 
 
     }
 
     // Update is called once per frame
     void Update()
     {
 
         THISISTHELITERALSLOTONE = THISISTHEACTUALLIST[0];
 
         THISISTHELITERALSLOTTWO = THISISTHEACTUALLIST[1];
 
         THISISTHELITERALSLOTTHREE = THISISTHEACTUALLIST[2];
 
         if (THISISTHEACTUALLIST[0] == 1)
         {
             ALICEstaysuplateoften.SetActive(true);
             ALICEstaysuplateoften.transform.position = THESEARETHECOORDINATESOFSLOTONE;
         }
 
         if (THISISTHEACTUALLIST[1] == 1)
         {
             ALICEstaysuplateoften.SetActive(true);
             ALICEstaysuplateoften.transform.position = THESEARETHECOORDINATESOFSLOTTWO;
         }
 
         if (THISISTHEACTUALLIST[2] == 1)
         {
             ALICEstaysuplateoften.SetActive(true);
             ALICEstaysuplateoften.transform.position = THESEARETHECOORDINATESOFSLOTTHREE;
         }
 
         if (THISISTHEACTUALLIST[0] == 2)
         {
             ALICElikestheearlymorning.SetActive(true);
             ALICElikestheearlymorning.transform.position = THESEARETHECOORDINATESOFSLOTONE;
             
         }
 
         if (THISISTHEACTUALLIST[1] == 2)
         {
             ALICElikestheearlymorning.SetActive(true);
             ALICElikestheearlymorning.transform.position = THESEARETHECOORDINATESOFSLOTTWO;
             
         }
 
         if (THISISTHEACTUALLIST[2] == 2)
         {
             ALICElikestheearlymorning.SetActive(true);
             ALICElikestheearlymorning.transform.position = THESEARETHECOORDINATESOFSLOTTHREE;
             
         }
 
         if (THISISTHEACTUALLIST[0] == 3)
         {
             PETERisscaredofsylvia.SetActive(true);
             PETERisscaredofsylvia.transform.position = THESEARETHECOORDINATESOFSLOTONE;
         }
 
         if (THISISTHEACTUALLIST[1] == 3)
         {
             PETERisscaredofsylvia.SetActive(true);
             PETERisscaredofsylvia.transform.position = THESEARETHECOORDINATESOFSLOTTWO;
         }
 
         if (THISISTHEACTUALLIST[2] == 3)
         {
             PETERisscaredofsylvia.SetActive(true);
             PETERisscaredofsylvia.transform.position = THESEARETHECOORDINATESOFSLOTTHREE;
         }
 
         if (THISISTHEACTUALLIST[0] == 4)
         {
             PETERisscaredofeverything.SetActive(true);
             PETERisscaredofeverything.transform.position = THESEARETHECOORDINATESOFSLOTONE;
         }
 
         if (THISISTHEACTUALLIST[1] == 4)
         {
             PETERisscaredofeverything.SetActive(true);
             PETERisscaredofeverything.transform.position = THESEARETHECOORDINATESOFSLOTTWO;
         }
 
         if (THISISTHEACTUALLIST[2] == 4)
         {
             PETERisscaredofeverything.SetActive(true);
             PETERisscaredofeverything.transform.position = THESEARETHECOORDINATESOFSLOTTHREE;
         }
     }
 }
 
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

0 Replies

· Add your reply
  • Sort: 

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

190 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

A more optimized way to adjust duplicate integer values In a list? 0 Answers

Best way to optimization for my game ? (4 device Profiler) 2 Answers

Trying to optimize android game for any phone 0 Answers

How can I not load all this map generation at once? 0 Answers

More efficient to have a simple script on many game objects or a list of game objects and cycle through it? 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges