Bomberman - bombAmountScript

Question

I'm making a bomberman-like game. Right now I want to make some kind of a "bomb ammunition" - if a player has at least one bomb and press a certain key, he makes a bomb - the bomb explodes. Bomb was made - one less bomb in the ammuntion, bomb exploded - one more bomb in ammunition. Here's my code :

 public class BombMaking : MonoBehaviour
 {
     public GameObject bomb;
     private static int bombAmount = 2;
     
     public void AddABomb()
     {
         bombAmount += 1;
 
     }
     public void SubstractABomb()
     {
         bombAmount -= 1;
     } 
 
     void MakeABomb()
     {
         Instantiate(bomb, Vector3Int.RoundToInt(this.gameObject.transform.position), Quaternion.identity);
     }
     void Update()
     {     
         if(Input.GetKeyDown("space") && bombAmount > 0)
         {
             MakeABomb();
             SubstractABomb();
         }
     }
 }

And the second part with bomb exploding :

  public GameObject player;
     private BombMaking bombMaking;
 public float explosionDuration = 0.4f;
 
     void Start()
     {
         bombMaking = player.GetComponent<BombMaking>();
         
     }
  public void Explode()
     { 
         // creating an explosion in a place where the bomb is
         GameObject explosion = Instantiate(explosionPrefab, this.gameObject.transform.position, Quaternion.identity) as GameObject;
         //destroying it
         Destroy(explosion, this.explosionDuration);
         // adding a bomb
         bombMaking.AddABomb();
     }

Everything works fine when I set the amount to 1, but when it comes to 2 something is wrong.... After explosion of the first 2 bombs I can make even 4, and when these 4 explode I can make much more... Maybe it's something with the static type, I'm not sure if I use it in a correct way... BombMaking script is attached to the player, code with Explode method is attached to the bomb. Explode is called when the animation of the bomb ends.

PS: I didn't show the rest of the code, I think it's not necessery ;)

Answer 1

Answer by NotNew · Feb 22, 2020 at 06:14 PM

Okay, so I solved this using the Invoke function and setting the time equal to the time that animation of the bomb lasts for, sth like this : public class BombMaking : MonoBehaviour { public GameObject bomb; public int bombAmount = 1;

     public void AddABomb()
     {
         bombAmount += 1;
     }
     public void SubstractABomb()
     {
         bombAmount -= 1;
     } 
 
     void MakeABomb()
     {
         Instantiate(bomb, Vector3Int.RoundToInt(this.gameObject.transform.position), Quaternion.identity);
     }
     void Update()
     {     
         if(Input.GetKeyDown("space") && bombAmount > 0)
         {
           
             SubstractABomb();
            
             MakeABomb();
             Invoke("AddABomb", 2f);
         }
     }
 }

And deleted the calls of AddABomb from Explode method. Is it okay to do it this way? I mean, I'm new to Unity so I don't know whether it's a piece of .... , or it's okay. Now everything works properly with it.

Add comment · Show 1 · Share

alwayscodeangry · Feb 23, 2020 at 01:08 AM 0

Share

There's an argument to be made that if it works, then it's okay :P

Personally I'd want to know why it didn't work in the first place (I still suspect Explode() is being called twice; animation events can be tricksy...), but if you're happy with it then that should be good enough!

Bomberman - bombAmountScript

1 Reply

Your answer

Follow this Question

Related Questions