Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by leonardoraele · Mar 02, 2014 at 01:25 AM · movementinputcharactercontrollerupdate

Why am I losing some inputs on Update function?

I wrote a simple C# script to control my character using CharacterController component, but I'm losing some Inputs from "Jump" button and I don't know what is happening.

My logic is very simple: I'm reading the input and calculating the next movement to be done in Update function and using CharacterController.Move on FixedUpdate function with the movement calculated before.

Here is my code:

 using UnityEngine;
 using System.Collections;
 
 [RequireComponent (typeof(CharacterController))]
 public class SimpleCharacterController : MonoBehaviour {
 
     //-------------------------- ATTRIBUTES --------------------------
 
     public float MoveSpeed = 4.0f;
     public float GravityForce = 0.3f;
     public float JumpStrength = 0.1f;
     public string JumpButton = "Jump";
     
     private float verticalSpeed = 0.0f;
     private Vector3 finalMovement = Vector3.zero;
     private UnityEngine.CharacterController controller;
 
     //------------------------- AWAKE FUNCTION -----------------------------
     
     public virtual void Awake()
     {
         controller = GetComponent<UnityEngine.CharacterController>();
     }
 
     //------------------------- UPDATE FUNCTION ----------------------------
     
     public void Update()
     {
         // Calculate character movement horizontally(x, z = movement) and vertically(y = gravity/jump)
         this.finalMovement = calculeMovement () + calculeGravityJump ();
     }
 
     private Vector3 calculeMovement()
     {
         float horizontal = Input.GetAxis("Horizontal");
         float vertical = Input.GetAxis("Vertical");
         
         return
                 transform.forward * vertical * MoveSpeed * Time.deltaTime +
                 transform.right * horizontal * MoveSpeed * Time.deltaTime;
         
     }
 
     // This method saves the current vertical speed to calculate the movement in the next updates
     private Vector3 calculeGravityJump()
     {
         // If the character is on the ground, vertical movement is nullified
         if (controller.isGrounded)
         {
             verticalSpeed = 0.0f;
         }
         // If character isn't on the ground, apply gravity to the vertical movement
         else
         {
             verticalSpeed = Mathf.Max(
                                       - GravityForce, // Limits maximum fall speed
                                       verticalSpeed - GravityForce * Time.deltaTime // Apply gravity to current speed
                                       );
         }
         
         // If press to jump and is able to jump, add vertical force
         if (Input.GetButtonDown(JumpButton) && isAbleToJump())
         {
             verticalSpeed = JumpStrength;
         }
         
         return Vector3.up * verticalSpeed;
     }
 
     public bool isAbleToJump()
     {
         return controller.isGrounded; // A character is able to jump whenever it is on ground
     }
     
     //-------------------------- FIXED UPDATE -----------------------------
 
     public void FixedUpdate ()
     {
         this.controller.Move (this.finalMovement);
     }
 
 }

Thank you for the help.

Comment
Add comment · Show 2
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image robertbu · Mar 02, 2014 at 01:29 AM 0
Share

Any chance you are getting slow frames (spikes in performance) where two Jumps would occur in a single frame?

avatar image leonardoraele · Mar 02, 2014 at 01:58 AM 0
Share

I don't know how to precisely check this... $$anonymous$$y game is running at around 76~84 fps. But I think even if this happens, the character would jump normally because in one of the frames the player pressed Jump button. No?

0 Replies

· Add your reply
  • Sort: 

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

20 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

The name 'Joystick' does not denote a valid type ('not found') 2 Answers

Input.GetAxis won't start working properly. 1 Answer

How to modify the base movement speed of the character in JS 1 Answer

Mouse movement swings character around in circles 1 Answer

Simple rigidbody.AddForce only applying once each time key is pressed 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges