Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by zardini123 · Feb 17, 2013 at 07:17 PM · if-statementsnullreferenceexeption

NullReferenceExeption on OnCharacterControllerHit

In my game, when a character jumps on a certain object, it is supposed to do something. As the code follows, when the character jumps on a object, the character takes the parent's name. Depending on the name, it will do something, but at the if.. then.. statement in the code, there is a NullReferenceExeption when the character jumps on anything. Heres the code:

 function OnControllerColliderHit (hit : ControllerColliderHit) {
     var name = hit.gameObject.transform.parent.name;
     if (name == "Thing") {
         Debug.Log("Yay!");
     }
 }
Comment
Add comment · Show 2
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image tuhinbhatt · Feb 17, 2013 at 07:27 PM 0
Share

What is the NullReference Exception you are getting . can you post the full exception(error) message?

avatar image zardini123 · Feb 17, 2013 at 11:32 PM 0
Share

Its a plain NullReferenceException

1 Reply

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by robertbu · Feb 17, 2013 at 07:42 PM

Your code will will generate a null reference exception if the game object you collided with does not have a parent. If parent == null then your "parent.name" will generate the exception.

Comment
Add comment · Show 5 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image zardini123 · Feb 17, 2013 at 11:31 PM 0
Share

I tried your idea with this code:

 function OnControllerColliderHit (hit : ControllerColliderHit) {
     var name : String;
     
     if (hit.collider.transform.childCount == 0) {
         name = hit.gameObject.transform.name;
     } else if (hit.collider.transform.childCount > 0) {  
         name = hit.gameObject.transform.parent.name;
     } 
     
     if (name == "Thing") {
         Debug.Log("Yay!");
     }
 }

Still, a NullReferenceException.

avatar image Starkid225 · Feb 17, 2013 at 11:42 PM 0
Share

The NullReferenceException should provide you will a line number. Could you post the full output of the error in the Error log?

avatar image zardini123 · Feb 18, 2013 at 12:12 AM 0
Share

Sure. It says: NullReferenceException CharacterDini.OnControllerColliderHit (UnityEngine.ControllerColliderHit hit) (at Assets/Zardainian Quest/Assets/Characters/$$anonymous$$ain Characters/Dini/CharacterDini.js:217) UnityEngine.CharacterController:$$anonymous$$ove(Vector3) CharacterDini:FixedUpdate() (at Assets/Zardainian Quest/Assets/Characters/$$anonymous$$ain Characters/Dini/CharacterDini.js:194)

Just letting you guys know, the line #'s don't coordinate with the code i have posted before, so yeah.

avatar image robertbu · Feb 18, 2013 at 01:12 AM 0
Share

I've never used childCount, but according to the reference, transform.childCount is the number of children of a specific transform. It does not indicate that the transform has a parent. I'd change your check to

 if (hit.collider.transform.parent == null)
avatar image zardini123 · Feb 18, 2013 at 02:05 PM 0
Share

That worked perfectly! Thank you!

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

11 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Combining if Statements 1 Answer

Single line if statement with many conditions or several single-conditioned if statements 1 Answer

Why does if(levelToLoad ==null) not work? 2 Answers

C# Declaring Variables Within If Statements 2 Answers

If/else statements working one way, and not the other 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges