Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 14 Next capture
2021 2022 2023
2 captures
12 Jun 22 - 14 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
0
Question by GuardHei · Nov 21, 2018 at 07:09 AM · shadershadersshader programmingshaderlabshader writing

Shader error : unexpected $end, expecting TOK_SETTEXTURE or '}' at line 18

I was writing a simple shader which could render a cuboid wireframe of the mesh. However, after compiled the shader, Unity gave out the following error:

Shader error in 'CuboidWireframeShader': Parse error: syntax error, unexpected $end, expecting TOK_SETTEXTURE or '}' at line 18

I am confused because at this line, Because there is only a CGPROGRAMn token. The full shader code is shown below:

 Shader "Custom/CuboidWireframeShader"
 {
     Properties
     {
         _Color ("Color", Color) = (1,1,1,1)
         _MainTex ("Main Texture", 2D) = "white" {}
         _Thickness ("Thickness", Float) = 1
     }
     
     SubShader
     {
         Pass
         {
             Tags { "RenderType"="Opaque" "Queue"="Geometry" }
             Blend SrcAlpha OneMinusSrcAlpha
             Cull Off
             
             CGPROGRAM
 
             #pragma target 4.0
             #pragma vertex vert
             #pragma fragment frag
             #pragma geometry geom
             #include "UnityCG.cginc"
             
             float _Thickness;
             float4 _Color;
             float4 _MainTex_ST;
             sampler2D _MainTex;
             
             struct v2g {
                 float4 pos : POSITION;
                 float2 uv : TEXCOORD0;
             }
             
             struct g2f {
                 float4 pos : POSITION;
                 float2 uv : TEXCOORD0;
                 float3 distance : TEXCOORD1;
             }
             
             v2g vert(appdata_base v) {
                 v2g o;
                 o.pos = UnityObjectToClipPos(v.vertex);
                 o.uv = TRANSFORM_TEX(v.texcoord, _MainTex);
                 return o;
             }
             
             [maxvertexcount(3)]
             void geom(triangle v2g p[3], inout TriangleStream<g2f> triStream) {
                 v2g np[3];
                 bool find = false;
                 for (int i = 0; i < 3 && !find; i++) {
                     for (int j = i + 1; j < 3 && !find; j++) {
                         if (abs(p[i].uv.x - p[j].uv.x) > 0.01f && abs(p[i].uv.y - p[j].uv.y) > 0.01f) {
                             np[0] = p[3 - i - j];
                             np[1] = p[i];
                             np[2] = p[j];
                             find = true;
                         }
                     }
                 }
                 
                 float2 p0 = _ScreenParams.xy * np[0].pos.xy / np[0].pos.w;
                 float2 p1 = _ScreenParams.xy * np[1].pos/xy / np[1].pos.w;
                 float2 p2 = _ScreenParams.xy * np[2].pos/xy / np[2].pos.w;  
                 float2 v0 = p2 - p1;
                 float2 v1 = p2 - p0;
                 float2 v2 = p1 - p0;                   
                 float area = abs(v1.x * v2.y - v1.y * v2.x);                 
                 float dist0 = area / length(v0);
                 float dist1 = area / length(v1);
                 float dist2 = area / length(v2);
                                
                 g2f pIn;
                 pIn.pos = np[0].pos;
                 pIn.uv = np[0].uv;
                 pIn.dist = float3(dist0, 0, 0);
                 triStream.Append(pIn);
                 
                 pIn.pos = np[1].pos;
                 pIn.uv = np[1].uv;
                 pIn.dist = float3(0, dist1, 0);
                 triStream.Append(pIn);
                 
                 pIn.pos = np[2].pos;
                 pIn.uv = np[2].uv;
                 pIn.dist = float3(0, 0, dist2);
                 triStream.Append(pIn);
             }
             
             float4 frag(g2f input) : COLOR {
                 float4 color = _Color * tex2D(_MainTex, input.uv);
                 float4 transColor = float4(0, 0, 0, 0);
                 color = (_Thickness > input.dist.y || _Thickness  > input.dist.z) ? targetColor : transColor;
                 if(color.a < 0.5f) discard;
                 else color.a = 1.0f;
                 return color;
             }
 
             ENDCG
         }
     }
 }



What have I done wrong with this shader? Thanks for helping!

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by conjugategames · Apr 07 at 08:29 PM

Take "Cull Off" up one level, out of the Pass {} scope

Comment
Add comment · Show 2 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image conjugategames · Apr 07 at 08:34 PM 0
Share

On further examination, I realize you might need to just remove the Pass entirely, and put everything in SubShader

avatar image GuardHei · Apr 07 at 08:39 PM 0
Share

Cull Off can be placed inside each pass. I don’t see a reason why it can’t.

Anyway it was already 4 years ago, but the answer to this question is due to a shader parser bug, which will result in error if you mix up spaces and tabs in your codes

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

223 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Operate the shader, rotate the material 90 degrees 0 Answers

Fog not working in my own Vertext Shader 2 Answers

Is it possible to set the 'ForceNoShadowCasting' SubShader Tag via shader properties or a custom material editor? 1 Answer

Translucent Transparent Diffuse Sprite Shader Edit 1 Answer

Is there any way to do multiple passes on a texture / in a fragment shader? 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges