Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 14 Next capture
2021 2022 2023
2 captures
12 Jun 22 - 14 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by TheBleedingNova · Aug 28, 2017 at 05:13 AM · c#dontdestroyonloadsingleton

DontDestroyOnLoad Duplicating Objects When Scene Reloaded

I'm aware this is a generic issue, but i'm having trouble understanding. When I reload my scene, I want to keep an object because it has previous time records. When the scene reloads, the object is kept, but another one is created because the scene has reloaded. How do I prevent this?

Comment
Add comment · Show 4
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Umresh · Aug 28, 2017 at 05:42 AM 1
Share

Instantiate that object on scene load and if its already there don't instantiate. Use player prefs to check if already instantiated

avatar image TheBleedingNova Umresh · Aug 28, 2017 at 06:17 AM 0
Share

I'll try that, thanks.

avatar image hexagonius · Aug 28, 2017 at 07:59 AM 0
Share

You should her familiar with how a singleton works. Then you know what to do to prevent this in any case.

avatar image JTAGames · Mar 26, 2021 at 01:00 PM 0
Share

We have a tutorial showing you how to make a dontdestroyonload script that you can put on as many gameobjects as you want without duplication between scenes.

https://www.youtube.com/watch?v=HXaFLm3gQws

1 Reply

· Add your reply
  • Sort: 
avatar image
2
Best Answer

Answer by Xarbrough · Aug 28, 2017 at 08:54 AM

The two most basic Unity-esque Singleton-like approaches look similar to this:

 public class MyBehaviour : MonoBehaviour
 {
     static MyBehaviour instance;
 
     void Awake()
     {
         if(instance == null)
         {    
             instance = this; // In first scene, make us the singleton.
             DontDestroyOnLoad(gameObject);
         }
         else if(instance != this)
             Destroy(gameObject); // On reload, singleton already set, so destroy duplicate.
     } 
 }
 
 public class MyBehaviour : MonoBehaviour
 {
     static MyBehaviour instance;
 
     public MyBehaviour GetInstance()
     {
         if(instance == null)
         {
             // Something similar to this to load and create the object when needed.
             Object prefab = Resources.Load("Path/To/Prefab"); // Look up the docs ;)
             GameObject go = Instantiate(prefab);
             instance = GetComponent<MyBehaviour>();
             DontDestroyOnLoad(go);
         }
         return instance;
     } 
 }

(my apologies, if there's an error, this is typed without a compiler)

You can either place your object in the scene, assign it to some persistent storage (usually a static variable for the lifetime of your app) and then destroy other duplicates, when you load a new scene.

The other approach is to only load and create the singleton object, when it is needed.

And as always the warning: Singletons are called dangerous or frowned upon by many developers, because they attract bad design decisions, especially in Unity and might cause bugs related to the static instance.

  • static variables are not garbage collected, you have to manage their lifetime yourself and set it to null, if you want the object to be freed from memory

  • there are typical mistakes, where you end up with duplicate instances of you intended singleton or leftover instances, which you don't want anymore (imagine a round-based fighting game, where the score manager still has a score from the last round and things like that)

  • singletons invite other code to just call it easily without a reference to it, creating lots of dependencies to this once class, which then might change and cause lots of cascading errors or lots of code changes

On the other hand, there's nothing wrong in using them correctly.

Comment
Add comment · Show 4 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image TheBleedingNova · Aug 28, 2017 at 07:50 PM 0
Share

Thank you! This is the best explanation I've found yet, thank you very much.

avatar image TheBleedingNova · Aug 28, 2017 at 11:53 PM 0
Share

The object isn't duplicated in DontDestroyOnLoad, but it is there in the main hierarchy every time I reload. How would I fix this? Thanks

avatar image iBicha TheBleedingNova · Aug 29, 2017 at 01:06 AM 1
Share

change Destroy(this); with Destroy(gameObject);

avatar image TheBleedingNova iBicha · Aug 29, 2017 at 01:21 AM 0
Share

You sir, are a life saver. Thank you so much to both of you. Have a great day!

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

380 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Singleton and DontDestroyOnLoad question 1 Answer

UNITY2D: How do I destroy previous object with Singleton Pattern? 0 Answers

Unity C# Singleton? 6 Answers

Preventing my game object from multiplying due to DontDestroyOnLoad() 2 Answers

Multiple Cars not working 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges