Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 14 Next capture
2021 2022 2023
2 captures
12 Jun 22 - 14 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by PlanarBit · Oct 06, 2018 at 08:48 PM · shader programmingcgfragment

Fragment shader with "return" in for loop crashes the game on Android

Maybe someone can explain this phenomena?

This fragment shader makes the game hang and then crash on Anrdoid device.

 fixed4 frag(v2f_grab IN) : SV_Target
 {
     fixed4 color = tex2Dproj(_GrabTexture, IN.uvgrab);
 
     if (_HasNewColor == 1 && ColorsAreEqual(color, _NewColor))
     {
         return _NewColorState;
     }
 
     for (uint i = 0; i < _ColorsToShowLength; i++)
     {
         if (ColorsAreEqual(color, _ColorsToShow[i]))
         {
             return color;
         }
     }
 
     color = 1;
 
     return fixed4(1,1,1,1);
 }
 

The issue disappears if I replace "return" with "break".

 fixed4 frag(v2f_grab IN) : SV_Target
 {
     fixed4 color = tex2Dproj(_GrabTexture, IN.uvgrab);
 
     if (_HasNewColor == 1 && ColorsAreEqual(color, _NewColor))
     {
         return _NewColorState;
     }
 
     bool shouldShow = false;
     for (uint i = 0; i < _ColorsToShowLength; i++)
     {
         if (ColorsAreEqual(color, _ColorsToShow[i]))
         {
             shouldShow = true;
             break;
         }
     }
 
     if (!shouldShow)
     {
         color = 1;
     }
 
     return color;
 }
Comment
Add comment · Show 1
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image BIGcheese89 · Jan 04, 2021 at 11:17 AM 0
Share

$$anonymous$$y shader does a return in the loop, although not crashing it causes artifacts.

In $$anonymous$$e I fixed it by exiting early setting 'i' to the 'length' (so like a break).

Seems like returning early in shaders is not a great idea, and definitely not in loops. I'm no expert with shaders, but I seem to remember there are complications with early exits, especially in older versions.

For example the clip function is known to have complications, or still continue execution anyway.

0 Replies

· Add your reply
  • Sort: 

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

96 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

How to convert surface shader to Vertex/Fragment code? 0 Answers

Shader that renders fragment behind 0 Answers

Multiple Vectors in shader/CGINC 0 Answers

Exported shader's output is black 0 Answers

How to implement scaling without scaling the texture. 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges