Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 14 Next capture
2021 2022 2023
2 captures
13 Jun 22 - 14 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by osdosd · Dec 11, 2021 at 10:36 PM · animationscripting problem2d gamebeginnermovement script

How do I stop moving when attacking?

In my 2D game the player can move around fine, but when I press the attack button (space) the attack animation plays but the character doesn't stop moving.

Here's my code:

 using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
 
 public enum PlayerState
 {
     walk,
     attack,
     interact
 }
 
 public class PlayerMovement : MonoBehaviour
 {
     public PlayerState currentState;
     public float moveSpeed;
     public Rigidbody2D rb;
     public Animator anim;
     private Vector2 moveDirection;
     private Vector2 lastMoveDirection;
 
     void Start()
     {
         currentState = PlayerState.walk;
     }
 
     void Update()
     {
         ProcessInputs();
     }
 
     void ProcessInputs()
     {
         float moveX = Input.GetAxisRaw("Horizontal");
         float moveY = Input.GetAxisRaw("Vertical");
 
         if((moveX == 0 && moveY == 0) && moveDirection.x != 0 || moveDirection.y != 0)
         {
             lastMoveDirection = moveDirection;
         }
 
         if(Input.GetButtonDown("attack") && currentState != PlayerState.attack)
         {
             StartCoroutine(AttackCo());
         }
 
         else if(currentState == PlayerState.walk)
         {
             Move();
             Animate();
         }
 
 
         moveDirection = new Vector2(moveX, moveY).normalized;
     }
 
     void Move() 
     {
         rb.velocity = new Vector2(moveDirection.x * moveSpeed, moveDirection.y * moveSpeed);
     }
 
     void Animate()
     {
         anim.SetFloat("AnimMoveX", moveDirection.x);
         anim.SetFloat("AnimMoveY", moveDirection.y);
         anim.SetFloat("AnimMoveMagnitude", moveDirection.magnitude);
         anim.SetFloat("AnimLastMoveX", lastMoveDirection.x);
         anim.SetFloat("AnimLastMoveY", lastMoveDirection.y);
     }
 
     private IEnumerator AttackCo()
     {
         anim.SetBool("Attacking", true);
         currentState = PlayerState.attack;
         yield return null;
         anim.SetBool("Attacking", false);
         yield return new WaitForSeconds(.3f);
         currentState = PlayerState.walk;
     }
 }

Thank you to anyone who has the brains to help! :D

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by lluisvinent4 · Dec 12, 2021 at 02:28 AM

Check if you are attacking before moving.

 if(Input.GetButtonDown("attack") && ...)
      attack
 else if(currentState == PlayerState.walk)
      move
 else if((moveX == 0 && moveY == 0) && ...)
      lastMoveDirection = moveDirection;

Comment
Add comment · Show 3 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image osdosd · Dec 12, 2021 at 01:58 PM 0
Share

The same thing happens: When I attack I can still move the character but the attack animation plays. Thank you for trying to help though!

avatar image lluisvinent4 osdosd · Dec 12, 2021 at 02:17 PM 0
Share

Try this

 if(Input.GetButtonDown("attack") && ...)
           attack
      else if(currentState == PlayerState.walk && currentState != PlayerState.attack)
           move
      else if((moveX == 0 && moveY == 0) && ...)
           lastMoveDirection = moveDirection;


avatar image osdosd lluisvinent4 · Dec 12, 2021 at 02:34 PM 0
Share

It still doesn't work. Maybe if it stops the function Move(); in the coroutine? Sorry for causing you this much trouble.

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

344 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

How can i normalize 2d Vectors? 2 Answers

How to set y rotation axis to 90 on 2d project, always, forever 1 Answer

First script plays animation but second script stops if from playing said animation 1 Answer

Character Animator controller/movement 1 Answer

How do i script basic attack animation? 3 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges