While Loop within For Loop crashes Game

Question

Hello! I want my Token spawn algorithm to not spawn more than 2 of the same type in a row. therefore i'm using a while loop within a for loop to check if the same color is within the spawn list more than 2 times.

I tried out several things but i can't see why this would produce an infinite loop:

 for (int i=0; i<_tokenList.Length; i++)
         {
             while (!canAddToken) {
             
             tokenToAdd = _tokenType[Random.Range(0,maxTokens)];
             createdTokenList.Add(tokenToAdd);
                 
             lastTokenAmount = 0;
 
             foreach (string tokenToCheck in createdTokenList)
                 {
                     if (tokenToCheck == tokenToAdd)
                     {
                         lastTokenAmount += 1;
                     }
                     
                 }
             
             if(lastTokenAmount > 2)
                 {
                     createdTokenList.Remove(tokenToAdd);
                     canAddToken = false;
                 }
             else
                 {
                     canAddToken = true;
                 }
             
             }
         
             _tokenList[i] = tokenToAdd;
             canAddToken = false;
     
         }

Answer 1

Answer by whydoidoit · Oct 22, 2013 at 07:24 PM

 for (int i=0; i<_tokenList.Length; i++)
        {
          while (!canAddToken) {
  
           tokenToAdd = _tokenType[Random.Range(0,maxTokens)];
  
           canAddToken = i<2 || !(tokenList[i-1] == tokenToAdd && tokenList[i-2] == tokenToAdd);
  
          }
  
          _tokenList[i] = tokenToAdd;
          canAddToken = false;
  
        }

Add comment · Show 4 · Share

whydoidoit · Oct 22, 2013 at 07:28 PM 0

Share

$$anonymous$$ade it a bit simpler in an edit

whydoidoit · Oct 22, 2013 at 07:31 PM 0

Share

Without the loop:

    for (int i=0; i<_tokenList.Length; i++)
    {
      
       var tokenIndex = Random.Range(0,maxTokens);
       tokenToAdd = _tokenType[tokenIndex];
        

      _tokenList[i] =  i<2 || !(tokenList[i-1] == tokenToAdd && tokenList[i-2] == tokenToAdd) ? tokenToAdd : _tokenType[(tokenIndex + 1) % _tokenType.Length];

 
    }

Tinytouchtales · Oct 22, 2013 at 07:42 PM 0

Share

thanks for the rather impressive answer, but the console says: Operator ==' cannot be applied to operands of type bool' and `string'

the content of my _tokenList are actually strings.

i'm using c# btw

flaviusxvii · Oct 22, 2013 at 07:59 PM 1

Share

(tokenList[i-1] == tokenList[i-2] == tokenToAdd)

Yeah that won't work.

While Loop within For Loop crashes Game

1 Reply

Your answer

Follow this Question

Related Questions