How to make script affect only one this game object

Question

Hello everyone. I am 3D modeller more than a programmer. But now I need several doors in my scene to be opened and closed.

What I have. Two doors. One animator controller attached to these doors. A couple of clips placed in this animator controller, that is for opening rotation and closing rotation. And DoorController script.

First I had an issue in which all of my doors were opened in one moment when I have triggered an OpenDoor animation. I resolve this problem by using a call to a certain object that Raycast hitting with, instead of just getting a local Animator object. But what problem I have now is: When I open one of the doors, my program assign a string value "Opened" to doorState parameter of ALL OF THE DOORS IN THE SCENE. This makes rest of the doors playing the wrong animation after all (because they still closed in real).

The question is: How can I use my script with only one instance of a door and store unique parameter's values for this only one instance. How can I send command in this script to only this one certain door, not to everyone that have this script attached? How can I call to Animator component of this only one instance of a door? Not to everyone that have this script attached.

 public class DoorController : MonoBehaviour {
 
     //Animator m_animator;
     public Camera m_camera;
     public float maxDistance = 2;
     private string doorState;
     RaycastHit hit;
 
     // Use this for initialization
     void Start () {
         //m_animator = gameObject.GetComponent<Animator>();
         doorState = "Closed";
 
     }
     
     // Update is called once per frame
     void Update () {
         
         if (Physics.Raycast(m_camera.transform.position, m_camera.transform.forward, out hit, maxDistance))
         {
             if (hit.transform.tag == "Door")
             {
                 if (Input.GetButtonDown("Use"))
                 {
                     OpenDoor();
                 }
             }
         }
     }
 
     void OpenDoor()
     {
         if (doorState == "Closed")
         {
             // Open a door
 
             //m_animator.SetTrigger("OpenDoor");
             hit.transform.GetComponent<Animator>().SetTrigger("OpenDoor");
             doorState = "Opened";
         }
         else
         {
             // Close a door
 
             //m_animator.SetTrigger("CloseDoor");
             hit.transform.GetComponent<Animator>().SetTrigger("CloseDoor");
             doorState = "Closed";
         }
     }
 }

Answer 1

Answer by Shemamforash · Jul 25, 2018 at 11:43 AM

Hey there! The issue here is that the raycast is being performed in every Update() on every door. This means that if your main camera hits any door in the scene, each raycast from each door is going to register as having hit a door. This will, in turn, set the state of every door to "Opened". You could either check that hit.gameObject == this, to ensure that only the door that is actually hit by the raycast is marked as "Opened", or do as @Zodiarc says and use a collider to check whether the player is within door opening range.

Personally, I would go down the collider route as it's simpler and doesn't involve casting rays every frame for every door.

As a side note, it would probably be better to perform the input check in the player script rather than the door script in order to centralise your input logic. You might also like to use an enum to indicate Open and Closed states for your door rather than strings. If you haven't used enums before it's definitely worth learning and can make your code a bit clearer.

Add comment · Show 1 · Share

Harinezumi · Jul 25, 2018 at 12:07 PM 0

Share

You are right, nice catch!
The separate raycasts detect any door, but activate the door on which the script is.

Answer 2

Answer by Zodiarc · Jul 25, 2018 at 07:55 AM

That's how I would do it:

Add a collider to the player and check the isTrigger (or similar) checkmark. Then write something similar to that:

 class DoorController: MonoBehaviour {
 
     private Animator animator;
     public bool open = false;
 
     public void Start() {
         this.animator = GetComponent<Animator>();
     }
 
     public void OnTriggerStay(Collider other) {
         if(Input.GetButtonDown("Use")) {
             open = !open;
             animator.SetBool("Open", open);
         }
     }
 }

OnTriggerStay will only be called when the collider of the door is within a trigger collider, so only one door should be affected. Note: I didn't check if it actually works. To improve it further you can also check if the other collider is the player

Add comment · Show 3 · Share

dom_cobb_22 · Jul 25, 2018 at 12:27 PM 0

Share

$$anonymous$$ade it. Now doors just shaking. Close-Close-Close-Close-Close repeat... Tin-tin-tin-tin-tin.... alt text

After all, a script is work. The door opens and closes. But the last animation is repeating.

dom_cobb_22 · Jul 25, 2018 at 01:22 PM 0

Share

Everything is good. Just use Trigger ins$$anonymous$$d of a Bool in Animator.

Thank you.

 public void OnTriggerStay(Collider other)
     {
         if (Input.GetButtonDown("Use") && other.tag == "Player")
         {
             if (open == false)
             {
                 m_animator.SetTrigger("OpenDoor");
             }
             else
             {
                 m_animator.SetTrigger("CloseDoor");
             }
 
             open = !open;
 
             
         }
     }

ADDITION: Animation playing all the time if you use Bool in Animator. It's playing once if you use Trigger.

dom_cobb_22 · Aug 14, 2018 at 04:16 AM 0

Share

Hello there. In continuous of this idea...

Now I have this code:

 public void OnTriggerStay(Collider other)
     {
         if (Input.GetButtonDown("Use") && other.tag == "Player")
         {
             if (open == false)
             {
                 switch (gameObject.tag)
                 {
                     case "Door95":
                         m_animator.SetTrigger("OpenDoor95");
                         break;
                     case "Door105":
                         m_animator.SetTrigger("OpenDoor105");
                         break;
                     case "Door120":
                         m_animator.SetTrigger("OpenDoor120");
                         break;
                     default:
                         break;
                 }
 
                     Debug.Log("OPEN DOOR");
             }
             else
             {
                 switch (gameObject.tag)
                 {
                     case "Door95":
                         m_animator.SetTrigger("CloseDoor95");
                         break;
                     case "Door105":
                         m_animator.SetTrigger("CloseDoor105");
                         break;
                     case "Door120":
                         m_animator.SetTrigger("CloseDoor120");
                         break;
                     default:
                         break;
                 }
 
                 Debug.Log("CLOSE DOOR");
             }
 
             open = !open;
             Debug.Log("CHANGE OPEN");
         }
     }

But sometimes my door open and close with one button pressing (and sometimes - not). What could it be?

$$anonymous$$y keyboard is alright.

Pay attention to time keys. alt text

opendoorconsole.png (31.3 kB)

How to make script affect only one this game object

2 Replies

Your answer

Follow this Question

Related Questions