Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 14 Next capture
2021 2022 2023
2 captures
13 Jun 22 - 14 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Gilead7 · Nov 01, 2021 at 04:58 PM · c#eventsdelegates

Stack Overflow error on delegate call

This is very puzzling! I'm working on a quest system and have chosen to use c# events. I have a quest giver script placed on a model, I have a quest panel that tells the player about quest and gives them the choice via button to accept the quest or not( yes button and no button). I also have a journal script to keep track of current and completed quests. I set up a delegate and event for OnAcceptQuest. Just as a test, I set up a keypress to add the quest, which worked. Only when I try using the button, it didn't work at all; the quest was getting lost so I found a way around that, I thought. Now I'm getting a Stack Overflow error when I try to add the quest via click on a button image. This post is a little long-winded, but I am trying to give as much info as possible. Now for the code:

Event Manager: public class EventsManager { //Quests public delegate void QuestAddDelegate(QuestClass quest); public static QuestAddDelegate OnAcceptQuestEvent; public static void AcceptQuest(QuestClass quest) {

         if(OnAcceptQuestEvent != null)
         {
             OnAcceptQuestEvent(quest);
         }
     }
 }

Quest Giver: private void OnTriggerEnter() { print("Open panel"); OpenQuestPanel(); }

     private void OnTriggerExit()
     {
         print("Close panel");
         CloseQuestPanel();
     }
 
     private void OnEnable()
     {
         EventsManager.OnAcceptQuestEvent += AddQuest;
     }
 
     private void OnDisable()
     {
         EventsManager.OnAcceptQuestEvent -= AddQuest;
     }
 
     public void OpenQuestPanel()
     {
         if(Quest.questStatus == QuestStatus.Unassigned)
         {
             QuestPanel.SetActive(true);
             PresentQuest();
         }
 
         else if(Quest.questStatus == QuestStatus.InProcess)
         {
             QuestPanel.SetActive(false);
             ProgressRewardPanel.SetActive(true);
             QuestInProgress();
 
         }
         else if (Quest.questStatus == QuestStatus.Complete)
         {
             Rewards();
         }
         
     }
 
     public void CloseQuestPanel()
     {
 
         QuestPanel.SetActive(false);
         
     }
 
     void PresentQuest()
     {
         QuestPanel.SetActive(true);
         IntroText.text = Quest.introText;
         QuestDescText.text = Quest.questDescription;
         RewardText.text = "You will receive " + Quest.reward + " for your trouble.";
     }
 
     //public void OnClickYes()
     //{
         //questAccepted = true;
     //    Debug.Log("Yes, accept the Quest!");
 
     //    AddQuest(Quest);
         //checkquest();
         // Add quest to the active quest list
         // change icon to hourglass
     //}
 
   
     public void OnClick()
     {
         Debug.Log("Yes, accept the Quest!");
         AddQuest(Quest);
     }
 
     public void OnClickNo()
     {
         
         RefusalText.text = Quest.refusalText;
         
     }
 
    
 
 
     void AddQuest(QuestClass quest)
     {
         EventsManager.AcceptQuest(quest);
         Quest.questStatus = QuestStatus.InProcess;
 
     }
 
   
 }
 Journal:
 private void OnEnable()
     {
         EventsManager.OnAcceptQuestEvent += AddQuest;
         EventsManager.OnCancelQuestEvent += RemoveQuest;
     }
 
     private void OnDisable()
     {
         EventsManager.OnAcceptQuestEvent -= AddQuest;
         EventsManager.OnCancelQuestEvent -= RemoveQuest;
     }
 
     void Start()
     {
         
     }
 
    
     void Update()
     {
         
     }
 
     void AddQuest(QuestClass quest)
     {
         CurrentQuestList.Add(quest);
         print(CurrentQuestList.Count);
         ShowCurrentQuests();
     }
 
     void RemoveQuest(QuestClass quest)
     {
         CurrentQuestList.Remove(quest);
         print(CurrentQuestList.Count);
     }

Test script:

  void Update()
     {
         if (Input.GetKeyDown(KeyCode.Q))
         {
             print("Q");
             EventsManager.AcceptQuest(quest);
         }

Thanks in advance!

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

2 Replies

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by Gilead7 · Nov 04, 2021 at 04:56 PM

Thanks Bunny! It took some time, but for those of you following at home... I had things mixed up. I didn't need the onEnable and onDisable nor did I need the AcceptQuest functions in the QuestGiver script. I thought the questgiver needed to know that the player accepted the quest, but that wasn't the case. I made a new function that is called when the player clicks on the yes button, rather than using an image and an onclick function. In that function I called the event and as long as the panel was open, it worked! Thanks again Bunny for giving me just what I needed to figure out the rest. First time using events/delegates so this is kinda new to me. Hope this helps somebody out there!

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
0

Answer by Bunny83 · Nov 01, 2021 at 05:09 PM

To quote the relevant parts from your code:

 public static QuestAddDelegate OnAcceptQuestEvent;
 public static void AcceptQuest(QuestClass quest)
 {
         if(OnAcceptQuestEvent != null)
         {
             OnAcceptQuestEvent(quest);
         }
     }
 }
 
 private void OnEnable()
 {
     EventsManager.OnAcceptQuestEvent += AddQuest;
 }
 
 void AddQuest(QuestClass quest)
 {
     EventsManager.AcceptQuest(quest);
     Quest.questStatus = QuestStatus.InProcess;
 }

Look at those snippets carefully if you can see your issue.

Try just follow the execution

 AcceptQuest --> OnAcceptQuestEvent --> AddQuest --> AcceptQuest --> ...
Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Gilead7 · Nov 01, 2021 at 05:50 PM 0
Share

That explains it, what do I do to fix it?

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

742 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Fire C# Event 3 Answers

Subscribers of Delegates? 2 Answers

Question about unsubscribing eventhandlers OnDisable and OnEnable 2 Answers

How do Delegates and Events work? 1 Answer

Multiple Cars not working 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges