Data from a simple singleton / static class return null

Question

Here is my code for a singleton called Statistics :

 public static Statistics instance;
     public int numberOfEnnemyKilled=0;
 
     private void Awake()
     {
         if (instance == null)
         {
             instance = this;
         } else
         {
             Destroy(this);
         }
     }
 
     public string GetTextEnnemyKilled()
     {
         return instance.numberOfEnnemyKilled.ToString();
     }

When i call it like that in another script :

 text.text = Statistics.instance.GetTextEnnemyKilled();

I get the error NullReferenceException: Object reference not set to an instance of an object, saying that this function return null. I dont know what I'm doing wrong. Thanks!

Answer 1

Best Answer

Answer by icehex · Apr 29, 2020 at 06:57 AM

It doesn't look like you're initializing instance.numberOfEnnemyKilled. Also you only posted some of your code so I'm not sure how to interpret what you have shown. You could try:

      public static Statistics instance;
  
      private void Awake()
      {
          if (instance == null)
          {
              instance = this;
              instance.numberOfEnnemyKilled = 0;
          } 
         else
          {
              Destroy(this);
          }
      }
  
      public string GetTextEnnemyKilled()
      {
          return instance.numberOfEnnemyKilled.ToString();
      }

Add comment · Show 5 · Share

Quest_for_stuff · Apr 29, 2020 at 07:10 AM 0

Share

Hey, thank you for answering ^^ Unfortunetly I still have the error NullReferenceException: Object reference not set to an instance of an object Testing.Update() ligne 16 Testing class :

  public class Testing : $$anonymous$$onoBehaviour
     {
         Text$$anonymous$$eshPro text;
     
         private void Start()
         {
             text = GetComponent<Text$$anonymous$$eshPro>();
         }
         private void Update()
         {
             text.text = Statistics.instance.GetTextEnnemyKilled(); //ligne16
         }
     }

Statistic class :

 public class Statistics : $$anonymous$$onoBehaviour
 {
 
     public static Statistics instance;
     public int numberOfEnnemyKilled=0;
 
     private void Awake()
     {
         if (instance == null)
         {
             instance = this;
             instance.numberOfEnnemyKilled = 0;
 
         } else
         {
             Destroy(this);
         }
     }
 
 
     public string GetTextEnnemyKilled()
     {
         return instance.numberOfEnnemyKilled.ToString();
     }
 }

![alt text][1]

Hope this can help! [1]: /storage/temp/158028-saveds.png

saveds.png (38.5 kB)

icehex Quest_for_stuff · Apr 29, 2020 at 08:22 AM 1

Share

Took me a moment to figure this out --- the error isn't because you're calling Statistics. It's because you're calling text.text. So somewhere along the lines, the element 'text' within 'text' (the TextmeshPro component) is not initialized. Do you have a Text$$anonymous$$eshPro component attached to your GameObject Canvas? Is the component "Text" the Text$$anonymous$$eshPro? $$anonymous$$aybe you'd need ins$$anonymous$$d:

              text = GetComponent<Text>();

Quest_for_stuff icehex · Apr 29, 2020 at 08:38 AM 0

Share

I can't believe that was it. I had a Text component and not a TextTeshTro component attached to my object.. I feel so dumb. Honestly, thank you very very much for taking the time to answer me, you saved me. Thank you a lot!!

Show more comments

Data from a simple singleton / static class return null

1 Reply

Your answer

Follow this Question

Related Questions