Random Object Pooler

Question

Hi all, i have an object pooler script which has multiple objects inside it. i have another script which spawns these objects in order, i wish to make this random but i am really stuck. advice greatly appreciated .... public class FinalObjPool : MonoBehaviour { public static FinalObjPool instance;

 public List<GameObject> pooledObjects;
 public int countToPool = 3;
 public bool canExpand = false;
 void Awake()
 {

     if(instance == null)
     {
         instance = this;
     }

     pooledObjects = new List<GameObject>();
     foreach (GameObject p in platforms)
     {
         for (int i = 0; i < numOfEachHelix; ++i)
         {
             GameObject obj = Instantiate(p);
             obj.SetActive(false);
             pooledObjects.Add(obj);
         }
     }
 }

////// //// i wish to pass a random value in here

 public GameObject GetPooledObject()
 {
     
     for (int i = 0; i < pooledObjects.Count; i++){
         if (!pooledObjects[i].activeInHierarchy)
         {
             return pooledObjects[i];
         }           
     }
     return null;
 }

}

//second script//

public class FinalPlatGen : MonoBehaviour {

 // Update is called once per frame
 void FixedUpdate()
 {
     OnObjectSpawn();
 }

 public Transform genPoint;
 System.Random rand;

 List<int> spawnDegree = new List<int> { 30, 60, 90, 120, 150, 180, 210, 240, 270 };

 // Update is called once per frame
 public void OnObjectSpawn()
 {

     if (transform.position.y + 5 < genPoint.position.y)
     {
         int RotationValue = Random.Range(0, spawnDegree.Count);
         int randomVal = spawnDegree[RotationValue];
         transform.position = new Vector3(0, transform.position.y + 3, 0);

///i wish to make this part random

         GameObject newPlatform = FinalObjPool.instance.GetPooledObject();


         if (newPlatform == null)
         {
             Debug.Log("NONE");
             return;
         }
         newPlatform.transform.position = transform.position;
         newPlatform.transform.Rotate(0, randomVal, 0);

         newPlatform.transform.SetParent(helix);
         newPlatform.SetActive(true);
     }
 }

}

Answer 1

Best Answer

Answer by Hellium · Apr 30, 2019 at 10:36 PM

  public GameObject GetPooledObject()
  {
      // Filter the list of pooled object and put all the inactive ones into a new list
      List<GameObject> inactiveObjects = pooledObjects.FindAll( go => !go.activeInHierarchy );

      // Check if the list created above has elements
      // If so, pick a random one,
      // Return null otherwise
      return inactiveObjects.Count > 0 ?
          inactiveObjects[ Random.Range(0, inactiveObjects.Count) ] :
          null;
  }

Add comment · Show 5 · Share

Captain_Pineapple · Apr 30, 2019 at 10:43 PM 0

Share

Nicely done! I like your solution.

MasterChameleonGames · Apr 30, 2019 at 10:48 PM 0

Share

Nice, but you might want to explain how it works.

Hellium MasterChameleonGames · May 01, 2019 at 08:33 AM 0

Share

I believe a code of 4 lines is not that complicated to understand, only the FindAll function can be hard to grasp if you have never encountered it. But anyway, I've commented on the code for better clarity.

MasterChameleonGames Hellium · May 01, 2019 at 11:18 AM 0

Share

Well, code of any length can be complicated, and besides, it will be easier for the op to understand and possibly use again.

Show more comments

Answer 2

Answer by Captain_Pineapple · Apr 30, 2019 at 10:41 PM

Hey there,

how about you shuffel your list when you created it? Something along the line:

     List<GameObject> shuffeledList = new List<GameObject>();
     while(pooledObjects.Count > 0)
     {
         shuffeledList.Add(pooledObjects[Random.Range(pooledObjects.Count)]);
     }
     pooledObjects = shuffeledList;

This way you will get the same order of objects but it's not the instantiation order. If this does not work for you, then you have to iterate ovver the whole list, remember the indices that were active and then choose a random value from this list of indices. Another way would be to keep 2 seperate lists, one for active objects, one for inactive. Then you can simply choose any random object from this active list. The latter might even be a bit better on performance.

Let me know what you think or if you need any further information.

Add comment · Show 1 · Share

cdalyz · May 01, 2019 at 05:33 PM 0

Share

good solution, tried both but @Hellium 's solution was more suited. Thanks for your solution too!

Answer 3

Answer by Righteousice · Feb 26, 2021 at 09:35 PM

Was having similar issue: public GameObject GetPooledObject() {

  for (int i = 0; i < pooledObjects.Count; i++){
      if (!pooledObjects[i].activeInHierarchy)
      {
          return pooledObjects[i];
      }           
  }
  return null;

}

Use:

public GameObject GetPooledObject() {

  for (int i = 0; i < pooledObjects.Count; i++){
      if (!pooledObjects[i].activeInHierarchy)
      {
          return pooledObjects[Random.Range(i, pooledObjects.Count];
      }           
  }
  return null;

}

This pulled a random pooled object without any issue.

Add comment · Share

Random Object Pooler

3 Replies

Your answer

Follow this Question

Related Questions