Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 14 Next capture
2021 2022 2023
2 captures
12 Jun 22 - 14 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
  • Help Room /
avatar image
2
Question by InkaTorque · Feb 17, 2019 at 07:10 AM · c#post processingcustompost-process-effect

How to properly declare a TextureParameter in a Custom PostProcessing Effect?

Hello guys , I'm having a bit of troubke when trying to make cuatom postbprocessing effects that require extra texgures . Here is my code :

 [Serializable]
 [PostProcess(typeof(TextureOverlayRenderer), PostProcessEvent.BeforeStack, "Custom/TextureOverlay")]
 public sealed class PostProcessingEffect_TextureOverlay : PostProcessEffectSettings
 {
     [Tooltip("Texture To Apply")]
     public TextureParameter overlayTexture = new TextureParameter();
     [Range(1.0f, 20.0f), Tooltip("Texture Repeat Factor")]
     public FloatParameter textureRepeatFactor = new FloatParameter { value = 1.0f };
     [Range(0f, 1f), Tooltip("Effect Opacity")]
     public FloatParameter opacity = new FloatParameter { value = 0.5f };
 
     public override bool IsEnabledAndSupported(PostProcessRenderContext context)
     {
         return enabled.value && (overlayTexture != null) && (opacity>0);
     }
 }
 
 public sealed class TextureOverlayRenderer : PostProcessEffectRenderer<PostProcessingEffect_TextureOverlay>
 {
     public override void Render(PostProcessRenderContext context)
     {
         var sheet = context.propertySheets.Get(Shader.Find("Hidden/Custom/TextureOverlay"));
         sheet.properties.SetTexture("_OverlayTexture", settings.overlayTexture);
         sheet.properties.SetFloat("_TextureRepeatFactor", settings.textureRepeatFactor);
         sheet.properties.SetFloat("_EffectOpacity", settings.opacity);
         context.command.BlitFullscreenTriangle(context.source, context.destination, sheet, 0);
     }
 }

As you can see , I´m declaring the texture and setting it to new TextureParameter(). However in editor I'm always getting erros concerning that texture. The most common one is "Argument Null Exception , Argument cannot be null. Parameter Name:Value"

I really don't know what to do , when I move something in the effect editor or add the effect to the post processing cinemachine component those errors show up . But whem I'm in play mode they seem to go away.

Comment
Add comment · Show 4
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image zereda-games · Feb 17, 2019 at 07:27 AM 0
Share
  public override bool IsEnabledAndSupported(PostProcessRenderContext context)//<--
  {
      return enabled.value && (overlayTexture != null) && (opacity>0);
  }

[<--] what is this doing? It obviously is required for an override so you need to do something with it i think that that is causing your null ref error.

avatar image zereda-games zereda-games · Feb 17, 2019 at 07:30 AM 0
Share
  public override bool IsEnabledAndSupported(PostProcessRenderContext context)
  {

      TextureOverlayRenderer.Render(context);// not sure if this is the problem..

      return enabled.value && (overlayTexture != null) && (opacity>0);
  }
avatar image zereda-games zereda-games · Feb 17, 2019 at 07:32 AM 0
Share

well actually, i don't think that wouldwork because its a sealed class

avatar image zereda-games · Feb 17, 2019 at 07:35 AM 0
Share

PS. Thanks didn't know you could do that. Sure cleans stuff up Big time!!

  [Range(0f, 1f), Tooltip("Effect Opacity")]

over:

  [Range(0f, 1f)]
  [Tooltip("Effect Opacity")]

4 Replies

· Add your reply
  • Sort: 
avatar image
0

Answer by InkaTorque · Feb 19, 2019 at 06:14 AM

Anyone?? No one??? Because of those null references the setup of the post process in every virtual camera is getting erased randomly

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
0

Answer by watsonsong · Feb 22, 2020 at 05:37 AM

@InkaTorque, Have you resolve this, I think I met the same problem.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
0

Answer by sharkwithlasers · Mar 24, 2020 at 06:33 AM

EDIT: Found a solution to this. The sequence of steps I used is as follows:

  1. Add the TextureParameter to the *Settings class

  2. Add this post processing effect as an effect in your post processing profile.

  3. Set the texture in your post processing profile

  4. Add the sheet.properties.SetTexture(...) statement in your *Renderer class.

This is a hacky fix, but it worked for me. I could definitely see this being super tedious when using this effect across many different profiles/projects (you'll need to comment out step 4, set the texture as in step 4, then uncomment out your comment).

I'd love to know if there is a better solution to this, however.


Original Post: I'm getting the same issue as well. Even when I have a null check in the Render function.

No clue what's going on.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image
0

Answer by yl_tys · Jul 22, 2021 at 09:49 AM

// Reference (UnityPackage: Post Processing Texture Overlay)

 public sealed class PostMask : PostProcessEffectSettings
 {
     public TextureParameter maskTex = new TextureParameter { value = null };
 }
 
 public sealed class PostMaskRenderer : PostProcessEffectRenderer
 {
     public override void Render(PostProcessRenderContext context)
     {
         var sheet = context.propertySheets.Get(Shader.Find("Hidden/tys/PostMask"));
 
         var imageTexture = settings.maskTex.value == null? RuntimeUtilities.whiteTexture: settings.maskTex.value;
         sheet.properties.SetTexture("_MaskTex", imageTexture);
         context.command.BlitFullscreenTriangle(context.source, context.destination, sheet, 0);
     }
 }
Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

656 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Why am I getting error when using postprocessing v2 on profile.TryGetSettings ? 0 Answers

why the effects of the Post Processing stack do not activate through an if-statement 0 Answers

Making a Kuwahara Filter Post process Shader (I'm using HDRP) 0 Answers

Setting Lift-Gamma-Gain values from C# script? (URP, Post-Processing v2) 1 Answer

Post Processing at UI 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges