Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by RayJr · Dec 29, 2014 at 04:33 PM · 2dspritelag

Update Color on ALL sprites simultaneously

HI,

I have a 2D game and I want to have a day/night cycle. I have it working but performance is slow. I have this script attached to ALL my sprites, so that they get brighter and darker based on the suns position and i would like to add a cloud cover adjustment as well. right now there are about 30 sprites in the scene.

Is there a way I can constantly update the brightness on everything without slowing things down?

Thanks!!

 public class Shadow: MonoBehaviour {
 
     
     public float sunPosition;  // starting position is 5.6
        GameObject oSun;
     float RGB;
     public float minLight = 0.05f;
  public float startLight = 5.9f;
 
     
     void Update () {
 
                 
         oSun = GameObject.Find ("sun");
         SpriteRenderer renderer = GetComponent<SpriteRenderer> ();
     sunPosition = oSun.transform.position.y;
 
         
         RGB = (sunPosition - startLight);
 
         if (RGB < minLight)
             renderer.color = new Color (minLight, minLight, minLight, 1f);
         if (RGB > minLight && RGB <= 1.0f)
             renderer.color = new Color (RGB, RGB, RGB, 1f);
 
                 
         }
 }
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by Thom Denick · Dec 29, 2014 at 04:40 PM

Generally, you never want to put GameObject.Find in an Update loop. It's super slow.

Instead, move this to Start:

 SpriteRenderer myRenderer;
 GameObject oSun;
 private void Start()
 {
   oSun = GameObject.Find ("sun");
  myRenderer = GetComponent<SpriteRenderer> ();
 }

And delete the same line in Update. I'd also recommend doing the same thing to your SpriteRenderer line.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

27 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Unity 5.1.1 Transform Lag/Bug 0 Answers

Prevent 2D mask to impact other gameobjects ? 3 Answers

Finding the centre of two touches 2 Answers

Should sprites in the same layer but different order incur additional draw calls? 0 Answers

How to make not smooth animation? 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges