Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by PurpleIce · May 14, 2015 at 10:05 AM · c#beginnernot working

Interact with Objects around the player

So I made a method that shall damage Objects with the tag Enemy near the player. But it doesn't work correctly, i dont actually know why i made gave the enemy the tag player, and attached both scripts to player and enemy

 public int damage = 50;
 public float range = 1f;
 private List <GameObject> enemys = new List <GameObject>();

 void Update () 
 {
 
         if(Input.GetButton("Fire0"))
         {
             Attack();
         }
 }

     protected void Attack()
     {
 
         Vector3 center = transform.position;
         
         Collider[] hitColliders = Physics.OverlapSphere(center, range);
 
         
         int i=0;
 
         while(i<hitColliders.Length)
         {
             
             if(hitColliders[i].tag=="Enemy")
             {
                 enemys.Add(hitColliders[i].gameObject);
             }
             i++;
         }
 
         for(i=0; i < enemys.Count; i++)
         {
             enemys[i].GetComponent<Enemy>().recieveDmg(damage);
         }
     }


 public class Enemy : MonoBehaviour
 {
     public int life = 100;
 
     void Update()
     {
         if(life == 0)
         {
             gameObject.SetActive(false);
         }
     }
 
     public void recieveDmg(int damage)
     {
         life -= damage;
     }
 
 }
 

I only copied the important parts of the code, if you need anything more pls let me know :/

Comment
Add comment · Show 10
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image xortrox · May 14, 2015 at 10:10 AM 0
Share

your check for the enemy dying where life reaches 0 will pretty much hardly happen as well as you simply do life -= damage in the receiveDmg function you will often end up below zero. To fix this you could just do this after applying damage in receiveDmg:

 if(life < 0)
 {
 
 life = 0;
 
 }

This is a common mistake I see in a lot of games too actually, where healthbars end up going off in the negative direction because of how their UI functions. So when the value goes below zero the "fill" is overdrawn to the left usually.

avatar image xortrox · May 14, 2015 at 10:12 AM 0
Share

You might also want to clear your enemys List every time a new attack starts so that you dont call receiveDmg on outdated references to enemies. Unless your attack sort of clings to the enemies ofcourse.

avatar image xortrox · May 14, 2015 at 10:15 AM 0
Share

Other than this I'm not sure what could be wrong here other than making sure that each object has the required tag and generally debugging to make sure your code is being executed at all using Debug.Log

avatar image PurpleIce · May 14, 2015 at 11:05 AM 0
Share

I tested the code with the debugger and the code within the while-loop isn#t executed so i think the overlapSphere is giving 0 Objects to the array.

avatar image xortrox · May 14, 2015 at 11:14 AM 0
Share

That could be because you have a range of 1 set in your script.

Show more comments

0 Replies

· Add your reply
  • Sort: 

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

3 People are following this question.

avatar image avatar image avatar image

Related Questions

Double Jump 1 Answer

My jumping script isn't working, And it isn't giving me any errors,My character isn't jumping, But I don't get any errors 1 Answer

Multiple Cars not working 1 Answer

Distribute terrain in zones 3 Answers

How Can I Make My Fire Effect Disappear After I Shoot Object? 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges