koobas.hobune.stream
Other
Select Car - Multiple prefabs
Hello!
I have a problem with my car models. I've made it so that the player can choose which car model he uses, and to do that I've added six different car-prefabs to the scene, and then setting all but the selected car model to .SetActive (false).
My problem occurs when I hit play in the Unity editor. All the prefabs that are not active appear briefly at the start in the scene before disappearing. Why is this happening and how can I fix it?
Thanks in advance!
void Awake ()
{
savedCar = PlayerPrefs.GetInt ("Selected Car");
car01Prefab = GameObject.Find ("Car01");
mainCamera01 = GameObject.Find ("Main Camera 01");
car02Prefab = GameObject.Find ("Car02");
mainCamera01 = GameObject.Find ("Main Camera 02");
car03Prefab = GameObject.Find ("Car03");
mainCamera01 = GameObject.Find ("Main Camera 03");
car04Prefab = GameObject.Find ("Car04");
mainCamera01 = GameObject.Find ("Main Camera 04");
car05Prefab = GameObject.Find ("Car05");
mainCamera01 = GameObject.Find ("Main Camera 05");
car06Prefab = GameObject.Find ("Car06");
mainCamera01 = GameObject.Find ("Main Camera 06");
if (savedCar == 0) {
car01Prefab.SetActive (true);
mainCamera01.SetActive (true);
car02Prefab.SetActive (false);
mainCamera02.SetActive (false);
car03Prefab.SetActive (false);
mainCamera03.SetActive (false);
car04Prefab.SetActive (false);
mainCamera04.SetActive (false);
car05Prefab.SetActive (false);
mainCamera05.SetActive (false);
car06Prefab.SetActive (false);
mainCamera06.SetActive (false);
} else if (savedCar == 1) {
car01Prefab.SetActive (true);
mainCamera01.SetActive (true);
car02Prefab.SetActive (false);
mainCamera02.SetActive (false);
car03Prefab.SetActive (false);
mainCamera03.SetActive (false);
car04Prefab.SetActive (false);
mainCamera04.SetActive (false);
car05Prefab.SetActive (false);
mainCamera05.SetActive (false);
car06Prefab.SetActive (false);
mainCamera06.SetActive (false);
} else if (savedCar == 2) {
car01Prefab.SetActive (false);
mainCamera01.SetActive (false);
car02Prefab.SetActive (true);
mainCamera02.SetActive (true);
car03Prefab.SetActive (false);
mainCamera03.SetActive (false);
car04Prefab.SetActive (false);
mainCamera04.SetActive (false);
car05Prefab.SetActive (false);
mainCamera05.SetActive (false);
car06Prefab.SetActive (false);
mainCamera06.SetActive (false);
} else if (savedCar == 3) {
car01Prefab.SetActive (false);
mainCamera01.SetActive (false);
car02Prefab.SetActive (false);
mainCamera02.SetActive (false);
car03Prefab.SetActive (true);
mainCamera03.SetActive (true);
car04Prefab.SetActive (false);
mainCamera04.SetActive (false);
car05Prefab.SetActive (false);
mainCamera05.SetActive (false);
car06Prefab.SetActive (false);
mainCamera06.SetActive (false);
} else if (savedCar == 4) {
car01Prefab.SetActive (false);
mainCamera01.SetActive (false);
car02Prefab.SetActive (false);
mainCamera02.SetActive (false);
car03Prefab.SetActive (false);
mainCamera03.SetActive (false);
car04Prefab.SetActive (true);
mainCamera04.SetActive (true);
car05Prefab.SetActive (false);
mainCamera05.SetActive (false);
car06Prefab.SetActive (false);
mainCamera06.SetActive (false);
} else if (savedCar == 5) {
car01Prefab.SetActive (false);
mainCamera01.SetActive (false);
car02Prefab.SetActive (false);
mainCamera02.SetActive (false);
car03Prefab.SetActive (false);
mainCamera03.SetActive (false);
car04Prefab.SetActive (false);
mainCamera04.SetActive (false);
car05Prefab.SetActive (true);
mainCamera05.SetActive (true);
car06Prefab.SetActive (false);
mainCamera06.SetActive (false);
} else if (savedCar == 6) {
car01Prefab.SetActive (false);
mainCamera01.SetActive (false);
car02Prefab.SetActive (false);
mainCamera02.SetActive (false);
car03Prefab.SetActive (false);
mainCamera03.SetActive (false);
car04Prefab.SetActive (false);
mainCamera04.SetActive (false);
car05Prefab.SetActive (false);
mainCamera05.SetActive (false);
car06Prefab.SetActive (true);
mainCamera06.SetActive (true);
}
}
I don't know why it's happening... perhaps it's because the find function is slow so while it goes you are still seeing the vehicles?
Regardless, here's a quick fix that wouldn't fix the root of the problem but rather fixes the symptoms. Put all of your cars in an empty gameObject at 0,0,0. Then move that gameObject off screen in your inspector. Once all of the cars are loaded and the one you want is set to Active, just change the transform of that gameObject to 0,0,0.
I didn't mark that as an answer, however, because someone else will likely come along and offer a real solution. But I know a lot of people right now are working on Global Game Jam games and for those people a quick solution is probably the best one.
Well I am not working on Global Game Jam games, but thank you for the band-aid fix!
As for the original question I would start by making sure the savedCar variable is getting correctly set to a number between 1 and 6. Secondly, I know this wasn't part of your question, but you could cut down on a lot of code by using an array and a loop. I wrote this quick, so it might have some kinks, but here's the general idea:
private GameObject[] cars;
private GameObject[] cameras;
private int numberOfCars = 6;
void Awake()
{
savedCar = PlayerPrefs.GetInt ("Selected Car");
cars = new GameObject[numberOfCars];
cameras = new GameObject[numberOfCars];
for(int i = 1; i <= numberOfCars; i++)
{
cars[i - 1] = GameObject.Find ("Car0" + i);
cameras[i - 1] = GameObject.Find ("$$anonymous$$ain Camera 0" + i);
if(savedCar == i)
{
cars[i - 1].SetActive(true);
cameras[i - 1].SetActive(true);
}
else
{
cars[i - 1].SetActive(false);
cameras[i - 1].SetActive(false);
}
}
}
@LessThanEpic +1 for improving the original code, but this is not an answer, so I converted it to a comment.
I've got it now. Forgot to add wheel colliders to cars. Just copied each model and decided that I would add wheel colliders later.
No wonder they were "disappearing" from the scene since they just fell through the ground...
Thanks everyone for your help.
