Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Cammi · Jul 24, 2014 at 10:58 PM · 2dmovementcharactergetkeydown

GetKey and GetKeyDown are always registered? [Answered]

I'm very much new to programming and to unity and I was able to follow a simple tutorial to make a ball game, (I'm certain most of you know the one) however when I went off to try and make a 2d plat former of my own the Player Character is always moving and I have no idea how to fix the issue.

 function Update () {
     Movement();
 }
 
 function Movement () {
     if(Input.GetKeyDown(KeyCode.RightArrow));
     {
         //transform.Translate(Vector2.right * 4f * Time.deltaTime);
         Debug.Log ("Rightio");
     }
     if(Input.GetKeyDown(KeyCode.LeftArrow));
     {
         //transform.Translate(-Vector2.right *4f * Time.deltaTime);
         Debug.Log ("Leftadoodle");
     }
 }

I used the Debug.Log s to see what was going on. This is to say, when I run the game preview I get an endless stream of "Rightio" and Leftadoodle."

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

2 Replies

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by rutter · Jul 24, 2014 at 11:00 PM

You see the semicolon at the end of these lines?

 if(Input.GetKeyDown(KeyCode.RightArrow));

 if(Input.GetKeyDown(KeyCode.LeftArrow));

Get rid of those semicolons. In general, don't ever put a semicolon between an if and the block of code it's controlling.

This StackOverflow post will explain why, if you're curious. The post is for Java, but it turns out that this quirk of syntax is a problem in many programming languages. :)

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Cammi · Jul 24, 2014 at 11:05 PM 0
Share

Ah, I see! Thank you so much! That works just perfectly. Now I can work on picking up my hair and making a wig~

avatar image
0

Answer by Fabulous-Design · Jul 25, 2014 at 05:54 AM

Here is the good code:

function Update () {

 Movement();

}

function Movement () {

 if (Input.GetKey(KeyCode.RightArrow))
 {
     rigidbody.AddForce(Vector3.right * 200 * Time.deltaTime);
 }
 
 if (Input.GetKey(KeyCode.LeftArrow))
 {
     rigidbody.AddForce(Vector3.left * 200 * Time.deltaTime);
 }

}

message me if it doens't work.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

4 People are following this question.

avatar image avatar image avatar image avatar image

Related Questions

The name 'Joystick' does not denote a valid type ('not found') 2 Answers

Enemy not moving towards Player 0 Answers

Changing the jump key in a premade code 4 Answers

Make characters go through each other 1 Answer

Unity 4.3 2D make character not so blurry when moved 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges