Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 12 Next capture
2021 2022 2023
1 capture
12 Jun 22 - 12 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by GreyArea · Nov 15, 2016 at 08:47 AM · serializationundo

undo redo + custom serialization slow

I’m working on an editor for a hexagonal game board. Once a HexBoard is in the scene and selected in the Hierarchy one can place tiles onto the board by clicking the appropriate hexagon in the scene view. HexBoardEditor provides bunch of buttons to select the tile type, handles events and applies the necessary changes to HexBoard when a tile is clicked. This works just fine. I can save/load etc. Undo/Redo though are very slow (1-2s) and dragging across the board completely freezes everything for a few seconds. I’ve made an effort to only call RecordObject when the board will actually change, but it seems to make no difference. I’ve noticed that GameState.OnBeforeSerialize is constantly being called when HexBoard is selected in the hierarchy, but this seems to be something outside my control. I’ve added the relevant code snippets below. I would be grateful for any explanation or advice.

many thanks

 [Serializable]
 public class GameState : ISerializationCallbackReceiver
 {
        // WorldState is plain C# 
     private WorldState<BoardCoordinates, GameResourceBundle> _worldState;
 
     [SerializeField]
         private byte[] _serializedState;
 
         public void OnBeforeSerialize()
         {
           ... 
             bf.Serialize(stream, _worldState);
             _serializedState = stream.ToArray();
            }
 
         public void OnAfterDeserialize()
         {
         ...
     }
 }
 
 public class HexBoard : MonoBehaviour
 {
        [SerializeField]
        public GameState HexBoardState;
 
     … views GameState by creating/updating a mesh
 }
 
 public HexBoardEditor()
 {
         private void OnSceneGUI()
         {
          if (... board object will be changed ...)
                 {
                     if (e.type != EventType.MouseDrag)
                     {
                         Undo.RecordObject(hexBoard, _editActions[selectedFeatureIndex].Name);
                     }
            hexBoard.SomeMethodThatChangesGameState()
 
     }
 }

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

0 Replies

· Add your reply
  • Sort: 

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

3 People are following this question.

avatar image avatar image avatar image

Related Questions

Using Undo.RecordObject() does not protect a component's variables from being reverted to the prefab on play. 0 Answers

BeginChangeCheck & EndChangeCheck not working? 1 Answer

Custom Editor serializing data in prefab instance. 0 Answers

Undo.RecordObject is too slow on large arrays, alternatives? 1 Answer

Undo problems with a Custom EditorWindow 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges