Wayback Machinekoobas.hobune.stream
May JUN Jul
Previous capture 13 Next capture
2021 2022 2023
1 capture
13 Jun 22 - 13 Jun 22
sparklines
Close Help
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by $$anonymous$$ · Aug 24, 2014 at 04:41 PM · c#errorfor loop

2-Dimensional Array Error [CLOSED]

Im having an issue with my code. It is giving me an error called IndexOutOfRangeException: Array index is out of range. Im not quite sure what Im doing wrong. The code is for a horror game with randomly generated levels...

Here is the code:

 using System.Collections;
 
 public class ProceduralGenerationScript : MonoBehaviour {
     public int worldX = 12;
     public int worldZ = 12;
 
     int[,] roomType;
 
     public GameObject room;
 
     // Use this for initialization
     void Start () {
         roomType = new int[worldX,worldZ];
         for(int i = 0; i <= worldX; i++)
         {
             for(int j = 0; j <= worldZ; j++)
             {
                 roomType[i, j] = 1;
                 }
 
                 //These Lines Seem To Error...
                 if(roomType[i, j] == 1)
                 {
                 Instantiate(room, new Vector3((float)i, 0, (float)j), Quaternion.identity);
                 }
 
             }
         }
     }
 }
 


The array roomType is used to index a certain room and decides what type of room it should be. Just now, it is set up to be that if roomType[i,j] is equal to 1, it will instanciate a roomplace holder(a plane). it works like this:

                 Instantiate(room, new Vector3((float)i, 0, (float)j), Quaternion.identity);


But not like this:

                 if(roomType[i, j] == 1)
                 {
                 Instantiate(room, new Vector3((float)i, 0, (float)j), Quaternion.identity);
                 }


Any help is appreciated! :-)

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by EvilTak · Aug 24, 2014 at 04:50 PM

In your for loops, you have given i <= worldX and j <= worldZ as the condition whereas it should be i < worldX and j < worldZ. When you instantiated your array, you mentioned the size as worldX and worldZ. Thus the last element would be worldX-1 and worldZ-1 since arrays start with index 0.

Comment
Add comment · Show 2 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image $$anonymous$$ · Aug 24, 2014 at 04:56 PM 0
Share

Ok, yep, I understand what I was doing wrong now! thank you. Also, extra points for the quick answer! Thank you.

I ended up going into negative numbers when the array starts at 0. Thank you.

avatar image EvilTak · Aug 24, 2014 at 05:05 PM 1
Share

If you thought the answer was appropriate and right, please mark it as correct.

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Follow this Question

Answers Answers and Comments

22 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Multiple Cars not working 1 Answer

Distribute terrain in zones 3 Answers

How to make a for loop for a class in C# 1 Answer

C# yield error 3 Answers

UNITY_MVP_MATRIX error when downloading A* Pathfinding 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges